[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670042#comment-16670042
]
Goldstein Lyor commented on SSHD-849:
-------------------------------------
Hi Roberto,
Quick reminder:
* :) {quote}Your code changes are acceptable for us, you can merge it into
master repo.{quote}
* :( {quote}Your committed changes do not work fine for us{quote}
No harm done, but let's try and be more thorough next time in order to avoid
this back and forth - I rely on your reports since you are the only one that
can reproduce the problem (for now at least...)
> Possible race condition for local port forwarding channels
> ----------------------------------------------------------
>
> Key: SSHD-849
> URL: https://issues.apache.org/jira/browse/SSHD-849
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.1.1
> Reporter: Roberto Deandrea
> Assignee: Goldstein Lyor
> Priority: Major
> Fix For: 2.1.1
>
>
> Hi Lyor,
> We found another critical race condition sending data through local port
> forwarding channels that causes loosing data bytes sent by client to target
> server.
> As soon as possible I will open a pull request with our potential changes to
> fix this issue.
> I let you know when done because I would like to know your feedback.
> Hi Lyor,
> We made some code changes to your proposed solution based on
> ClientChannelPendingMessageQueue.
> You can find our commit at
> https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d
> Can you review our code and give us feedback ?
> If it satisfies you can you merge it in Apache SSHD master repository ?
> Our definitive working code is at
> https://github.com/robertodeandrea/mina-sshd/commit/c381e522dc254387009d82612dc15f0c584dece6
> Cheers.
> Roberto
> Cheers
> Roberto
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
