[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674868#comment-16674868
]
ASF GitHub Bot commented on SSHD-849:
-------------------------------------
GitHub user robertodeandrea opened a pull request:
https://github.com/apache/mina-sshd/pull/79
Br ssh849
This is our definitve code to fix SSHD-849.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertodeandrea/mina-sshd br-SSH849
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit 9f2d49a97963d9f4330d96578142d67e06b44c07
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-09T07:37:46Z
SSHD-848 Proposed change code
commit ffc29c475cb6b0240807c7f20680e5a5a2c0db76
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-10T06:48:44Z
SSHD-848 Removed misleading comment.
commit 851b22fc431e4ed6ba440874f236d93a6aca9827
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-15T14:43:59Z
SSHD-849 Potential fix
commit 1970d8d045e1a40e64864157cc6d21591e1ca69e
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-16T06:53:43Z
Merge remote-tracking branch 'upstream/master'
# Conflicts:
#
sshd-core/src/main/java/org/apache/sshd/common/forward/DefaultForwardingFilter.java
commit 4523138ee2b4efa483bc956e8769eafb13eff05d
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-22T12:00:19Z
SSHD-849 Working code for us
commit c381e522dc254387009d82612dc15f0c584dece6
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-23T12:27:33Z
[SSHD-849] Definitive working code
commit 52a6ca93665156706186fabe9e98b7131628d7c5
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-31T11:08:46Z
Working code for SSHD-849
commit 4f74c40134b948d79fdf07024f263a2baecde648
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-31T11:15:42Z
Code rebase
commit 7c36667dd06e31676a0c97a2b171039b66d1eae9
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-31T11:19:09Z
Working code for SSHD-849
commit 5026f81fda5b238e3979a526c69118216da7a943
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-10-31T11:48:33Z
Version committed on Apache SSHD master
commit 68dcb0713b58ad7490fc5232eccdca32f521bb86
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-11-05T09:25:38Z
Version committed on master
commit a9527bf2189a4ac77aef5c76da665487797a5f52
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-11-05T09:28:03Z
[SSHD-849] Definitive code for fixing issue.
----
> Possible race condition for local port forwarding channels
> ----------------------------------------------------------
>
> Key: SSHD-849
> URL: https://issues.apache.org/jira/browse/SSHD-849
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.1.1
> Reporter: Roberto Deandrea
> Assignee: Goldstein Lyor
> Priority: Major
> Fix For: 2.1.1
>
>
> Hi Lyor,
> We found another critical race condition sending data through local port
> forwarding channels that causes loosing data bytes sent by client to target
> server.
> As soon as possible I will open a pull request with our potential changes to
> fix this issue.
> I let you know when done because I would like to know your feedback.
> Hi Lyor,
> We made some code changes to your proposed solution based on
> ClientChannelPendingMessageQueue.
> You can find our commit at
> https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d
> Can you review our code and give us feedback ?
> If it satisfies you can you merge it in Apache SSHD master repository ?
> Our definitive working code is at
> https://github.com/robertodeandrea/mina-sshd/commit/c381e522dc254387009d82612dc15f0c584dece6
> Cheers.
> Roberto
> Cheers
> Roberto
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
