[ https://issues.apache.org/jira/browse/SSHD-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830442#comment-16830442 ]
Goldstein Lyor commented on SSHD-912: ------------------------------------- [~roberto.deandrea] I have made some changes - please clone https://github.com/lgoldstein/mina-sshd/tree/SSHD-912 and see if it solves the deadlock. You can also review the changes in the associated PR - https://github.com/apache/mina-sshd/pull/102 I am still reviewing the code since it is a change in something very basic so I want to be sure we have not missed anything. > Review usages of AbstractCloseable#lock and constrain them only to actually > needed ones > --------------------------------------------------------------------------------------- > > Key: SSHD-912 > URL: https://issues.apache.org/jira/browse/SSHD-912 > Project: MINA SSHD > Issue Type: Improvement > Affects Versions: 2.2.0 > Reporter: Goldstein Lyor > Assignee: Goldstein Lyor > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The {{AbstractCloseable#lock}} is used in various {{Future}}-s but also for > stuff not related to them. We should take a look at it and separate these > uses so that {{AbstractCloseable#lock}} is used only for {{Future}}-s whereas > all other code uses a *separate* lock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)