[
https://issues.apache.org/jira/browse/SSHD-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837140#comment-16837140
]
Roberto Deandrea commented on SSHD-912:
---------------------------------------
Hi Lyor,
Yesterday I said you that no deadlock occurred with the new code changes, but I
spoke too early.... :(
I found a third thread deadlock on SSH client running our long run test always
during client/server disconnection.
The deadlock is as follows :
Thread #22175 name: sshd-SshClient[ad946082]-nio2-thread-2
---
org.apache.sshd.common.session.helpers.AbstractSession.doWritePacket(AbstractSession.java:873)
WAITFOR(encodedLock)
................
---
org.apache.sshd.common.session.helpers.AbstractSession.handleMessage(AbstractSession.java:362)
LOCKED(sessionLock)
Thread #22180 name: sshd-SshClient[ad946082]-nio2-thread-7
---
org.apache.sshd.client.session.ClientSessionImpl.signalAuthFailure(ClientSessionImpl.java:151)
WAITFOR(sessionLock)
.................
---
org.apache.sshd.common.session.helpers.AbstractSession.doWritePacket(AbstractSession.java:876)
LOCKED(encodedLock)
Attached you can find a full thread dump regarding the new deadlock. (see file
spxp.usrdump.9503...@aix72.dmz.20190510114505768.log)
Let me know if you prefer open a new ticket and troubleshoot this issue.
Kind Regards
Roberto Deandrea
> Review usages of AbstractCloseable#lock and constrain them only to actually
> needed ones
> ---------------------------------------------------------------------------------------
>
> Key: SSHD-912
> URL: https://issues.apache.org/jira/browse/SSHD-912
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Goldstein Lyor
> Assignee: Goldstein Lyor
> Priority: Major
> Fix For: 2.3.0
>
> Attachments: spxp.usrdump.9503...@aix72.dmz.20190510114505768.log
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{AbstractCloseable#lock}} is used in various {{Future}}-s but also for
> stuff not related to them. We should take a look at it and separate these
> uses so that {{AbstractCloseable#lock}} is used only for {{Future}}-s whereas
> all other code uses a *separate* lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
