lgoldstein commented on a change in pull request #119: Add support for openssh
host key certificates
URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408345027
##########
File path:
sshd-common/src/main/java/org/apache/sshd/common/keyprovider/KeyPairProvider.java
##########
@@ -83,8 +93,8 @@ public KeyPair loadKey(SessionContext session, String type) {
}
@Override
- public Iterable<String> getKeyTypes(SessionContext session) {
- return Collections.emptyList();
+ public Set<String> getKeyTypes(SessionContext session) {
Review comment:
Why change this ? I see no reason... - please revert the change or provide
compelling reason as to why this is 100% necessary. Please note that some code
may rely on `Iterable`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
