FliegenKLATSCH commented on a change in pull request #119: Add support for 
openssh host key certificates
URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408980789
 
 

 ##########
 File path: 
sshd-common/src/main/java/org/apache/sshd/common/keyprovider/KeyPairProvider.java
 ##########
 @@ -83,8 +93,8 @@ public KeyPair loadKey(SessionContext session, String type) {
             }
 
             @Override
-            public Iterable<String> getKeyTypes(SessionContext session) {
-                return Collections.emptyList();
+            public Set<String> getKeyTypes(SessionContext session) {
 
 Review comment:
   Hehe, I was pretty sure you would say this :) I don't have a reason except 
avoiding some back and forth converting, will change it back to `Iterable` 
again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to