[
https://issues.apache.org/jira/browse/SSHD-506?focusedWorklogId=436902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-436902
]
ASF GitHub Bot logged work on SSHD-506:
---------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/20 16:11
Start Date: 24/May/20 16:11
Worklog Time Spent: 10m
Work Description: lgoldstein commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-633253726
>> The tests all pass on my machine. I'm not sure what's going on with the
failing one on here.
That's OK - if you feel the code is ready as far as you are concerned, let
me know. Once I have examined it and successfully ran a full `mvn clean
install` on my machine I am willing to merge it. Our Travis builds are not yet
100% stable so if they fail but the tests succeed on my machine I usually
consider the code safe to merge.
That being said, please run some tests with OpenSSH clients/servers that
support these ciphers as well as some popular applications such as _Putty,
WinSCP, FileZilla_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 436902)
Time Spent: 3h 40m (was: 3.5h)
> Add support for aes128/256-gcm ciphers
> --------------------------------------
>
> Key: SSHD-506
> URL: https://issues.apache.org/jira/browse/SSHD-506
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Lyor Goldstein
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> See:
> * [rfc5647|https://tools.ietf.org/html/rfc5647]
> *
> [draft-igoe-secsh-aes-gcm-01|https://tools.ietf.org/html/draft-igoe-secsh-aes-gcm-01]
> * [OpenSSH v6.2|http://www.openssh.com/txt/release-6.2]
> * [JAVA AES 256 GCM encrypt/decrypt
> example|https://javainterviewpoint.com/java-aes-256-gcm-encryption-and-decryption/]
> - especially the usage of {{GCMParameterSpec}} to initialize the cipher
> * [OpenJDK 8 AESCipher.java source
> code|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/AESCipher.java]
> ** See also
> [CipherCore.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/CipherCore.java],
>
> [FeedbackCipher.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/FeedbackCipher.java],
>
> [GaloisCounterMode.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
