[
https://issues.apache.org/jira/browse/SSHD-506?focusedWorklogId=440551&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440551
]
ASF GitHub Bot logged work on SSHD-506:
---------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/20 01:34
Start Date: 03/Jun/20 01:34
Worklog Time Spent: 10m
Work Description: jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-637901360
Found one OSS implementation of the RFC version (disabled by default) in
Erlang OTP. Seems like the ambiguity about requiring a mac with an AEAD cipher
caused OpenSSH to create their variant in the first place. Docs:
https://manpages.ubuntu.com/manpages/bionic/man7/ssh.7.html
More notes here about the official ciphers:
https://www.iana.org/assignments/ssh-parameters/ssh-parameters.xhtml
Even if we were to take the spec literally, we could create another instance
of `Cipher.getInstance("AES/GCM/NoPadding")` and then only use the methods
`updateAAD()` and `doFinal()` to use it in GMAC mode. The problem there is that
the mac still wouldn't necessarily be used since it's already built in to an
AEAD operation.
I'll note this ambiguity is avoided in the OpenSSH ChaCha protocol:
https://cvsweb.openbsd.org/src/usr.bin/ssh/PROTOCOL.chacha20poly1305?annotate=HEAD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 440551)
Time Spent: 5h 10m (was: 5h)
> Add support for aes128/256-gcm ciphers
> --------------------------------------
>
> Key: SSHD-506
> URL: https://issues.apache.org/jira/browse/SSHD-506
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Lyor Goldstein
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> See:
> * [rfc5647|https://tools.ietf.org/html/rfc5647]
> *
> [draft-igoe-secsh-aes-gcm-01|https://tools.ietf.org/html/draft-igoe-secsh-aes-gcm-01]
> * [OpenSSH v6.2|http://www.openssh.com/txt/release-6.2]
> * [JAVA AES 256 GCM encrypt/decrypt
> example|https://javainterviewpoint.com/java-aes-256-gcm-encryption-and-decryption/]
> - especially the usage of {{GCMParameterSpec}} to initialize the cipher
> * [OpenJDK 8 AESCipher.java source
> code|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/AESCipher.java]
> ** See also
> [CipherCore.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/CipherCore.java],
>
> [FeedbackCipher.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/FeedbackCipher.java],
>
> [GaloisCounterMode.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
