[
https://issues.apache.org/jira/browse/SSHD-506?focusedWorklogId=445934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445934
]
ASF GitHub Bot logged work on SSHD-506:
---------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/20 16:55
Start Date: 15/Jun/20 16:55
Worklog Time Spent: 10m
Work Description: lgoldstein commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-644251850
>> Yes, I think so. I'm a little iffy on the BaseGCMCipher name for the
class as I'm imagining a different use of AES/GCM along the lines of how
OpenSSH implements ChaCha20-Poly1305 which would behave differently (the
additional authenticated data would be encrypted but not authenticated using
another AES key using AES/CTR like how in the packet length is encrypted).
We'll cross that bridge when we come to it - refactoring is not a dirty word
in this project
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 445934)
Time Spent: 6h 20m (was: 6h 10m)
> Add support for aes128/256-gcm ciphers
> --------------------------------------
>
> Key: SSHD-506
> URL: https://issues.apache.org/jira/browse/SSHD-506
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Lyor Goldstein
> Priority: Major
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> See:
> * [rfc5647|https://tools.ietf.org/html/rfc5647]
> *
> [draft-igoe-secsh-aes-gcm-01|https://tools.ietf.org/html/draft-igoe-secsh-aes-gcm-01]
> * [OpenSSH v6.2|http://www.openssh.com/txt/release-6.2]
> * [JAVA AES 256 GCM encrypt/decrypt
> example|https://javainterviewpoint.com/java-aes-256-gcm-encryption-and-decryption/]
> - especially the usage of {{GCMParameterSpec}} to initialize the cipher
> * [OpenJDK 8 AESCipher.java source
> code|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/AESCipher.java]
> ** See also
> [CipherCore.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/CipherCore.java],
>
> [FeedbackCipher.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/FeedbackCipher.java],
>
> [GaloisCounterMode.java|https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
