jvz commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r632719666
##########
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##########
@@ -70,6 +70,7 @@
*/
public static final List<BuiltinCiphers> DEFAULT_CIPHERS_PREFERENCE =
Collections.unmodifiableList(
Arrays.asList(
+ // BuiltinCiphers.cc20p1305_openssh, // TODO: enable by
default when BouncyCastle available
Review comment:
The copy of ChaCha I'm thinking of is one I wrote in the first place
based on the public domain reference implementation. However, if there's a
clean way to simply require BouncyCastle to enable this cipher, then we can
avoid any additional cipher code being copied. As I mentioned before, the main
problem here is that OpenSSH decided to use a pre-standardized version of
ChaCha20-Poly1305 which works slightly differently than the one bundled with
Java 11+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
