tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r632749447
##########
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##########
@@ -70,6 +70,7 @@
*/
public static final List<BuiltinCiphers> DEFAULT_CIPHERS_PREFERENCE =
Collections.unmodifiableList(
Arrays.asList(
+ // BuiltinCiphers.cc20p1305_openssh, // TODO: enable by
default when BouncyCastle available
Review comment:
If I understand you right, BC provides this pre-standard ChaCha cipher.
But SecurityUtils gives no clean way to ask for a "ChaCha" cipher from a
particular provider ("BC"). So that's what I was missing.
BuiltinCiphers.cc20p1305_openssh does check whether BC is registered, but in
ChaChaCipher when calling SecurityUtils.getCipher() there's no guarantee you
get the one from BC. Bypass SecurityUtils and ask via
Cipher.getInstance("ChaCha", "BC") directly? Or indeed include your own
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
