I don’t remember if I voted because I have been voting on a lot of stuff lately.
If I didn’t here is my +1 for all 3. Jeff > On Sep 12, 2023, at 2:29 AM, Emmanuel Lécharny <elecha...@gmail.com> wrote: > > Thanks Jeff & Gary. > > Is that for all the MINA versions? > > On 11/09/2023 16:27, Gary D. Gregory wrote: >> I can confirm a failure on Java 17 and Windows: >> [INFO] ------------------------------------------------------- >> [INFO] T E S T S >> [INFO] ------------------------------------------------------- >> [INFO] Running org.apache.mina.core.buffer.IoBufferHexDumperTest >> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.060 >> s -- in org.apache.mina.core.buffer.IoBufferHexDumperTest >> [INFO] Running org.apache.mina.core.buffer.IoBufferTest >> [ERROR] Tests run: 47, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: >> 0.404 s <<< FAILURE! -- in org.apache.mina.core.buffer.IoBufferTest >> [ERROR] org.apache.mina.core.buffer.IoBufferTest.testReadOnlyBuffer -- Time >> elapsed: 0.005 s <<< ERROR! >> java.nio.charset.CoderMalfunctionError: java.nio.ReadOnlyBufferException >> at >> java.base/java.nio.charset.CharsetEncoder.encode(CharsetEncoder.java:587) >> at >> org.apache.mina.core.buffer.AbstractIoBuffer.putString(AbstractIoBuffer.java:1798) >> at >> org.apache.mina.core.buffer.IoBufferTest.testReadOnlyBuffer(IoBufferTest.java:1104) >> at >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native >> Method) >> at >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) >> at >> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.base/java.lang.reflect.Method.invoke(Method.java:568) >> at >> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) >> at >> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) >> at >> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) >> at >> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) >> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) >> at >> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) >> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) >> at >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) >> at >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) >> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) >> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) >> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) >> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) >> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) >> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) >> at org.junit.runners.ParentRunner.run(ParentRunner.java:413) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155) >> at >> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385) >> at >> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) >> at >> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507) >> at >> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495) >> Caused by: java.nio.ReadOnlyBufferException >> at java.base/java.nio.HeapByteBufferR.put(HeapByteBufferR.java:212) >> at >> java.base/sun.nio.cs.ISO_8859_1$Encoder.encodeBufferLoop(ISO_8859_1.java:238) >> at >> java.base/sun.nio.cs.ISO_8859_1$Encoder.encodeLoop(ISO_8859_1.java:258) >> at >> java.base/java.nio.charset.CharsetEncoder.encode(CharsetEncoder.java:585) >> ... 30 more >> Using: >> Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) >> Maven home: C:\java\apache-maven-3.9.4 >> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program >> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot >> Default locale: en_US, platform encoding: Cp1252 >> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >> Gary >> On 2023/09/11 07:42:10 Jeff MAURY wrote: >>> +1. >>> >>> 2 remarks: >>> >>> - Does not build with Java 17 >>> - Build is failing on Windows >>> >>> >>> On Mon, Sep 11, 2023 at 8:11 AM Guillaume Nodet <gno...@apache.org> wrote: >>> >>>> +1 >>>> >>>> Le jeu. 7 sept. 2023 à 05:30, Emmanuel Lecharny <elecha...@apache.org> a >>>> écrit : >>>> >>>>> hi! >>>>> >>>>> WARNING: there are 3 votes to cast! >>>>> >>>>> >>>>> This is a vote for a triple release: >>>>> * MINA 2.2.3 >>>>> * MINA 2.1.8 >>>>> * MINA 2.0.25 >>>>> >>>>> Those versions are fixing a Datagram session bug: >>>>> DIRMINA-996:IoSessionRecycler RemoteAddress Collision >>>>> DIRMINA-1172:Multiple DatagramAcceptors and the creation of a session >>>>> object >>>>> >>>>> >>>>> >>>>> Temporary tags have been created (they can be removed if the vote is not >>>>> approved) : >>>>> >>>>> * MINA 2.2.3: >>>>> >>>>> >>>> https://github.com/apache/mina/commit/906884d52990b4fce119c462791abf1a5b577a83 >>>>> * MINA 2.1.8: >>>>> >>>>> >>>> https://github.com/apache/mina/commit/c7f164cbeecedb4a4e32ba798e7cf435acdc471a >>>>> * MINA 2.0.25: >>>>> >>>>> >>>> https://github.com/apache/mina/commit/38ca5a9eb01461a7212b3904ff5010d0364d2f41 >>>>> >>>>> >>>>> >>>>> >>>>> The final artifacts are stored in a staging repository: >>>>> * MINA 2.2.3: >>>>> https://repository.apache.org/content/repositories/orgapachemina-1086 >>>>> * MINA 2.1.8: >>>>> https://repository.apache.org/content/repositories/orgapachemina-1085 >>>>> * MINA 2.0.25: >>>>> https://repository.apache.org/content/repositories/orgapachemina-1087 >>>>> >>>>> >>>>> >>>>> The distributions are available for download on : >>>>> * MINA 2.2.3: https://dist.apache.org/repos/dist/dev/mina/mina/2.2.3 >>>>> * MINA 2.1.8: https://dist.apache.org/repos/dist/dev/mina/mina/2.1.8 >>>>> * MINA 2.0.25: https://dist.apache.org/repos/dist/dev/mina/mina/2.0.25 >>>>> >>>>> >>>>> Let us vote : >>>>> [ ] +1 | Release MINA 2.2.3 >>>>> [ ] ± | Abstain >>>>> [ ] -1 | Do *NOT* release MINA 2.2.3 >>>>> >>>>> [ ] +1 | Release MINA 2.1.8 >>>>> [ ] ± | Abstain >>>>> [ ] -1 | Do *NOT* release MINA 2.1.8 >>>>> >>>>> >>>>> [ ] +1 | Release MINA 2.0.25 >>>>> [ ] ± | Abstain >>>>> [ ] -1 | Do *NOT* release MINA 2.0.25 >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Cordialement, >>>>> Emmanuel Lécharny >>>>> www.iktek.com >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org >>>>> For additional commands, e-mail: dev-h...@mina.apache.org >>>>> >>>>> >>>> >>>> -- >>>> ------------------------ >>>> Guillaume Nodet >>>> >>> >>> >>> -- >>> "Legacy code" often differs from its suggested alternative by actually >>> working and scaling. >>> - Bjarne Stroustrup >>> >>> http://www.jeffmaury.com >>> http://riadiscuss.jeffmaury.com >>> http://www.twitter.com/jeffmaury >>> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org >> For additional commands, e-mail: dev-h...@mina.apache.org > > -- > *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE > T. +33 (0)4 89 97 36 50 > P. +33 (0)6 08 33 32 61 > emmanuel.lecha...@busit.com https://www.busit.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
