Hi!
My +1.
- Checked the signature
- Built with Java 8
- test passed green when I installed Docker
My main concern is that we now need to install Docker to get the test
passing, due to the usage of TestContainer. I don't really like it, the
build should be self-supported.
Add to that it took 25mins to ran the tests. TC is clearly slowing down
the whole tests (it takes around 10 s to start a new container):
[INFO] Apache Mina SSHD :: Common support utilits . SUCCESS [01:30 min]
...
[INFO] Apache Mina SSHD :: Core ................... SUCCESS [08:37 min]
[INFO] Apache Mina SSHD :: Mina ................... SUCCESS [03:41 min]
[INFO] Apache Mina SSHD :: Netty .................. SUCCESS [02:56 min]
...
[INFO] Apache Mina SSHD :: SFTP ................... SUCCESS [04:27 min]
[INFO]
------------------------------------------------------------------------
Frankly, I'm not a fan...
On 14/10/2023 16:04, Gary D. Gregory wrote:
Hi All:
+1
Lots of comments on this one; I am reviewing the src zip file:
- ASC OK
- Can't validate SHA file with:
shasum --check apache-sshd-2.9.3-src.zip.sha512
This is due to non-standard format for the file.
Eyeballing the file looks OK when compared to shasum -a 512 output.
- IMO, the VOTE email should include a link to the KEYS file.
The KEYS file is not even listed on
https://mina.apache.org/sshd-project/downloads.html
I had to go hunt for it: https://dist.apache.org/repos/dist/release/mina/KEYS
- Non-Blocker: Can't we just have SHA-512, instead of both SHA-512 and SHA-256?
- mvn apache-rat:check OK
- mvn clean install OK (but...)
- Tests fail unless you have admin rights, this should be documented in the
README IMO:
[ERROR] Errors:
[ERROR] org.apache.sshd.common.util.io.IoUtilsTest.testCheckExists
[ERROR] Run 1: IoUtilsTest.testCheckExists:74->testCheckExists:91 »
FileSystem
C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link:
A required privilege is not held by the client
[ERROR] Run 2: IoUtilsTest.testCheckExists:74->testCheckExists:91 »
FileSystem
C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link:
A required privilege is not held by the client
[ERROR] Run 3: IoUtilsTest.testCheckExists:74->testCheckExists:91 »
FileSystem
C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link:
A required privilege is not held by the client
- Tests fail randomly because they do not use ephemeral ports.
IOW, don't hardwire server socket ports in tests.
The tests should report which port is in error, whether or not ephemeral
ports are in use.
In this case, I had to hunt down what was using port 8080 on my machine and
temporarily stop that service.
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]
org.apache.sshd.common.forward.PortForwardingTest.testLocalBindingOnDifferentInterfaces
[ERROR] Run 1: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 »
Bind Address already in use: bind
[ERROR] Run 2: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 »
Bind Address already in use: bind
[ERROR] Run 3: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 »
Bind Address already in use: bind
[INFO]
[INFO]
[ERROR] Tests run: 556, Failures: 0, Errors: 1, Skipped: 8
- Using:
Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: C:\java\apache-maven-3.9.5
Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program
Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Gary
On 2023/10/12 14:33:21 Guillaume Nodet wrote:
I've staged a candidate release for 2.9.3 at:
Official staging repo:
https://dist.apache.org/repos/dist/dev/mina/sshd/2.9.3/
Maven staging repo:
https://repository.apache.org/content/repositories/orgapachemina-1088
Git tag:
https://github.com/apache/mina-sshd/commits/sshd-2.9.3
Changelog:
https://github.com/apache/mina-sshd/blob/sshd-2.9.3/docs/changes/2.9.3.md
Please review and vote !
--
------------------------
Guillaume Nodet
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
--
*Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
elecha...@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
