Le lun. 16 oct. 2023 à 22:02, Thomas Wolf <tw...@apache.org> a écrit :
> On 16.10.23 01:04 , Emmanuel Lécharny wrote: > > > My main concern is that we now need to install Docker to get the test > > passing, due to the usage of TestContainer. I don't really like it, the > > build should be self-supported. > > The use of TestContainers isn't new. > > > Add to that it took 25mins to ran the tests. TC is clearly slowing down > > the whole tests (it takes around 10 s to start a new container): > > > > [INFO] Apache Mina SSHD :: Common support utilits . SUCCESS [01:30 min] > > ... > > [INFO] Apache Mina SSHD :: Core ................... SUCCESS [08:37 min] > > [INFO] Apache Mina SSHD :: Mina ................... SUCCESS [03:41 min] > > [INFO] Apache Mina SSHD :: Netty .................. SUCCESS [02:56 min] > > ... > > [INFO] Apache Mina SSHD :: SFTP ................... SUCCESS [04:27 min] > > [INFO] > > ------------------------------------------------------------------------ > > > > > > Frankly, I'm not a fan... > > Do you know of a better and faster way of testing against different > versions of real OpenSSH (running on different OSes)? > > Some of the tests even capture the OpenSSH debug logging and verify that > it indicates certain conditions. > I'm not sure there are other ways. However, we could split tests between unit tests and integration tests (if needed) and across different profiles. Some profiles could only be activated by default in CI. > > Cheers, > > Thomas > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > -- ------------------------ Guillaume Nodet
