Jerome Lacoste wrote:
I'd like to release version 1.1-beta-2 of the exec Mojo plugin.
+1, my little use case for the exec:exec goal still runs. You could however consider to fix the failure to create the log output file in case its parent directory does not exist yet, i.e. <outputFile>target/this-does-not-exist/out.log</outputFile> will cause ExecMojo.java:268 to fail with a FileNotFoundException and output a warning. mkdirs() should cure this. Some mostly cosmetic issues that might be of interest to fix someday: The POM has no <scm> element, resulting in a wrong "Source Repository" report if it inherits from a released parent. A "mvn dependency:analyze" reports several used but undeclared dependencies. The title of the index page reads "[...] - Introduction to $project.name", "to $project.name" should be deleted. The index.html does not follow the Plugin Documentation Standard. The usage.html is rather long. Maybe it's worth to refactor out some paragraphs into example pages. The POM snippets on the usage page do not include a <version> element for the plugin. To teach users best practices, this would be good to have. Also consider that people will likely just copy your snippets over to their own POMs. The FAQ uses odd type-setting, e.g. "_execution_". Checkstyle and PMD report various violations. ExecMojo.java:51: warning - @description is a unknown tag (this tag is not part of the Mojo Annotation API). The parameter environmentVariables from the exec:exec goal has no description. The new parameter classpathScope is marked as @required although it has a default value. Hence, it is effectively optional for the user to specify in the plugin configuration, contrary to the goal documentation. Goal parameters have no @since annotation. Benjamin --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
