[
https://jira.codehaus.org/browse/MOJO-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=278298#comment-278298
]
Christopher Hunt commented on MOJO-1732:
----------------------------------------
@Marcel - I'm not exactly sure what the above comments are about, but you're
actually using src/main/less of course i.e. not src/main/webapp. I think it is
very important to make no assumptions about the packaging type within the
plugin. Outputting the result of less files to the target/classes
target/test-classes folder should be sufficient by default. Any other behaviour
can be configured.
Also I think you're going to have to use ANTLR to at least lex the less files
and build a hierarchical graph of imports. As stated before, invoking Rhino
each time for each file will be too slow given a reasonable project size;
particularly given that you're automatically binding to the process-sources
phases (your plugin will be invoked *every* time that someone saves a file in
Eclipse via m2eclipse behaviour). You *will* need to be selective about what
you process unless you resort to a packaging oriented phase.
On the subject of including the LessEngine: if all that the engine is doing is
invoking Rhino to process a js file that performs the lesscss functionality, I
would say own it and make it conform to the Mojo conventions. In addition,
write the unit tests for it and offer these back to the original developers.
The Apache 2 licence permits this so long as you retain the original licence
header and state the nature of your modifications alongside the header.
Alternatively including the original jar would be reasonable.
You also have check style warnings in your code. Please review the check style
report.
You should consider package level JavaDoc.
The project has now been added to the sandbox. Welcome to The Codehaus.
> Create project for lesscss Mojo
> -------------------------------
>
> Key: MOJO-1732
> URL: https://jira.codehaus.org/browse/MOJO-1732
> Project: Mojo
> Issue Type: New Feature
> Components: _Plugin Submission
> Reporter: Marcel Overdijk
> Assignee: Christopher Hunt
> Attachments: lesscss-maven-plugin.zip, lesscss-maven-plugin.zip,
> lesscss-maven-plugin.zip, lesscss-maven-plugin.zip
>
>
> As discussed on the mailing list I'm working on a new Maven plugin for
> lesscss (www.lesscss.org).
> Less is the dynamic stylesheet language and the plugin will provide
> compilation of .less files to ordinary .css files, mainly during the compile
> or package (war) phase.
> Could you please create this project in the sandbox so I can work on this?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
