[
https://jira.codehaus.org/browse/MOJO-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282761#comment-282761
]
Robert Scholte commented on MOJO-1767:
--------------------------------------
Sure you can. If you're using TortoiseSVN, there's an option on the Create
Patch-screen called "Show unversioned files", which you need to check.
I like the groovy-file, but the {{LogParser}} needs some modifications.
* The classname is too global if it is a specific {{BanDuplicateClasses}}
LogParser. We might need such LogParser for future rules as well, so some
splitting/refactoring might be required.
* the {{org.apache.maven}} package is there only for one reason: so your
configuration of the rules looks much smoother, since you don't have to specify
the implementation. In this case it should start with {{org.codehaus.mojo}}
* it will be confusing there's just a LogParser under {{src/test/java}} which
is only used by m-invoker-p.
This would already be an improvement, but we're not there yet. I'll try to
think of a cleaner solution too.
thanks!
> Improve integration-test for MOJO-1744
> --------------------------------------
>
> Key: MOJO-1767
> URL: https://jira.codehaus.org/browse/MOJO-1767
> Project: Mojo
> Issue Type: Improvement
> Components: extra-enforcer-rules
> Reporter: Robert Scholte
> Priority: Minor
> Attachments: LogParser.java, mojo-1744.it.2.patch
>
>
> With MOJO-1744 we have support for ignoring classes for specific dependencies.
> However, the IT seems unstable due to the usage of HashMaps (unpredictable
> order).
> The IT needs an improvement by ignoring the order, though every entry must be
> verified.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
