[
https://jira.codehaus.org/browse/MNBMODULE-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=288814#comment-288814
]
Frantisek Mantlik commented on MNBMODULE-155:
---------------------------------------------
build-installers-2.patch reflects Jesse's notes. More specific comments follow:
Comments concerning scripts replacements were included in the
BuildInstallersMojo.java in the place where patched scripts were copied. They
have been removed by the last patch and patches are made from pom as suggested.
template.xml does not need patch anymore as explained below, a very simple
patch of product.xml is made and commented in nbm-maven-harness/pom.xml lines
139-143. Newly, common.xml is patched to replace exec with ant task.
Typo > and Netbeans repo location have been fixed as suggested.
Unnecessary dependencies were removed from pom.
I can't find a way how to take rid of dependency on tools.jar . Even if a fake
native2ascii is created, build installers ant task fails because javac needs
tools.jar as well and compilation of installer application fails. Nevertheless,
tools.jar has to be a part of any jdk. If tools.jar is not present in ant's
classpath, javac task fails. If it is not acceptable to keep the dependency in
pom, other way how to fullfill the dependency requirement has to be found.
Please advice.
harness/config is not unpacked anymore. harness/modules/*.jar are needed in
compile classpath when installer is compiled. helloworld is the installer
application itself.
The installer branding part was completely redesigned better way, I believe.
Instead of defining of branding parameters in mojo and patching the template,
option of including user template was added and branding parameters were
removed from mojo. User template script overwrites template.xml. Parameters
provided in the userSettings map are passed to it in runtime. For example, if
patched template.xml included with previous build-installers.patch is pointed
by application's pom, following definition generates branded installers equal
to the result of previous patch version:
{code:xml}
<templateFile>../template.xml</templateFile>
<userSettings>
<nbi.icon.file>${basedir}/icon48.png</nbi.icon.file>
<nbi.icon16.file>${basedir}/icon.png</nbi.icon16.file>
<nbi.instleftcorner.file>${basedir}/ilc.png</nbi.instleftcorner.file>
<nbi.instrightcorner.file>${basedir}/irc.png</nbi.instrightcorner.file>
<nbi.instwelcometop.file>${basedir}/wlt.png</nbi.instwelcometop.file>
<nbi.instwelcomebottom.file>${basedir}/wlb.png</nbi.instwelcomebottom.file>
</userSettings>
{code}
installerLicenseFile type is now File. Nested exceptions are wrapped as
suggested.
commons.xml script is patched in pom to replace exec task with ant task. The
patch is a little tricky because exec parameters are passed in the original
script in the compact form, -DaName=aValue as a single parameter while ant task
needs <property name="aName" value="aValue" />. In addition, the task is called
several times with different nb.custom.parameter setting. Proposed patch works
for me, but any future change in commons.xml can lead to problems. Systematic
solution would be upstream change of exec tasks to ant which is out of the
scope of my possibilities, I guess.
Finally, props type is changed to Map<String,String>.
> Build installers goal
> ---------------------
>
> Key: MNBMODULE-155
> URL: https://jira.codehaus.org/browse/MNBMODULE-155
> Project: Maven NetBeans Module Plugin
> Issue Type: New Feature
> Affects Versions: 3.6
> Reporter: Frantisek Mantlik
> Assignee: Jesse Glick
> Attachments: build-installers-2.patch, build-installers.patch,
> nbm-installers-plugin.zip
>
>
> The proposal is to add a new goal which will provide similar functionality to
> "Build installers" action in IDE for mavenized RCP projects as a maven goal.
> I have developed a standalone plugin based on Ant-maven-plugin functionality
> which wrapped installer provided with Netbeans 6.9.1 and with minimum
> tweaking (mainly allowing some basic branding of generated installer) run an
> Ant task compiling and generating installers in the project application
> artifact. It is working for me on several mavenized RCP projects without any
> changes needed up to 7.1 RC1.
> I was trying to offer my plugin to Codehaus, but there was no interest -
> maybe because my advertisement was not good. I guess, that it should not be
> difficult to extract the goal from my plugin and integrate it to the
> nbm-maven-plugin as a new goal.
> Maybe, there would exist even easier way how to implement the same
> functionality to the nbm-maven-plugin?
> If there is interest in such a new feature, I could promise to do my best
> helping with development of the new goal. I am about to put one of my RCP
> projects to open-source domain and such a publicly available function would
> be helpful to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
