[ 
https://issues.apache.org/jira/browse/MRQL-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941276#comment-13941276
 ] 

Lee moon soo commented on MRQL-34:
----------------------------------

Thanks for reviewing.
Let me call two approach as hardwiring-way and generic-way.
I think both way test little bit different thing. Hardwiring-way compares 
output (object representation) and actual expected value, while generic-way is 
comparing two output (string representation) from different MRQL Evaluator 
implementations.
I think it make sense to keep both approaches for testing. 
My plan is, make junit test all existing queries in generic-way and make as 
much as possible hardwiring-way testing. If it is okay, let me handle it.
Thanks.





> Introduce junit for testing
> ---------------------------
>
>                 Key: MRQL-34
>                 URL: https://issues.apache.org/jira/browse/MRQL-34
>             Project: MRQL
>          Issue Type: Improvement
>            Reporter: Lee moon soo
>         Attachments: MRQL-34.patch
>
>
> MRQL has testcase and it's run as java standalone application by 
> org.apache.mrql.Test. 
> The Test class Invoked by maven antrun plugin at test phase
> and then load the queries and generate result and compare with the previous 
> result (if result exists)
> If junit runs those test case instead of antrun, it'll give some advantages
> 1. More common ways to adding / running test in Java
> 2. Once CI is setup, junit produces information for CI about details of test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to