[
https://issues.apache.org/jira/browse/MRQL-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971656#comment-13971656
]
Leonidas Fegaras commented on MRQL-34:
--------------------------------------
I applied "MRQL-34_b.patch" and run: mvn install.
The junit tests look fine but there are some bugs & improvements:
1) method EvaluatorTest.setUp() should not call createEvaluator();
2) The MRQL compiler generates many errors during testing:
Running org.apache.mrql.MapReduceQueryLocalModeTest
*** Compilation error at line 2 position 36: cannot find symbol
symbol: class Function
Must be a problem with linking with the MRQL classes. I had to set:
Config.compile_functional_arguments = false;
in QueryTest.queryAndCompare and EvaluatorTest.setUp to disable the compiler.
3) The tests should only be evaluated when:
mvn -Dtests install
They should not be evaluated when:
mvn install
4) mvn fails after building mapreduce. I had to do:
mvn -pl spark install
and:
mvn -pl bsp install
to build Spark and BSP mode
4) There are some test mismatches in BSP mode:
Failed tests: testJoins(org.apache.mrql.BSPQueryLocalModeTest): expected:<0>
but was:<84>
testLoop(org.apache.mrql.BSPQueryLocalModeTest): expected:<0> but was:<1>
testJoinGroupBy(org.apache.mrql.BSPQueryLocalModeTest): expected:<0> but
was:<6>
testMatrix(org.apache.mrql.BSPQueryLocalModeTest): expected:<0> but was:<8>
testPagerank(org.apache.mrql.BSPQueryLocalModeTest): expected:<0> but was:<1>
testNestedSelect(org.apache.mrql.BSPQueryLocalModeTest): expected:<0> but
was:<40>
testJoins(org.apache.mrql.BSPQueryInMemoryTest): expected:<0> but was:<84>
testLoop(org.apache.mrql.BSPQueryInMemoryTest): expected:<0> but was:<1>
testJoinGroupBy(org.apache.mrql.BSPQueryInMemoryTest): expected:<0> but
was:<6>
testMatrix(org.apache.mrql.BSPQueryInMemoryTest): expected:<0> but was:<8>
testPagerank(org.apache.mrql.BSPQueryInMemoryTest): expected:<0> but was:<1>
testNestedSelect(org.apache.mrql.BSPQueryInMemoryTest): expected:<0> but
was:<40>
Tests in error:
testFactorization(org.apache.mrql.BSPQueryLocalModeTest)
testFactorization(org.apache.mrql.BSPQueryInMemoryTest)
Tests run: 54, Failures: 12, Errors: 2, Skipped: 0
> Introduce junit for testing
> ---------------------------
>
> Key: MRQL-34
> URL: https://issues.apache.org/jira/browse/MRQL-34
> Project: MRQL
> Issue Type: Improvement
> Reporter: Lee moon soo
> Attachments: MRQL-34.patch, MRQL-34_a.patch, MRQL-34_b.patch
>
>
> MRQL has testcase and it's run as java standalone application by
> org.apache.mrql.Test.
> The Test class Invoked by maven antrun plugin at test phase
> and then load the queries and generate result and compare with the previous
> result (if result exists)
> If junit runs those test case instead of antrun, it'll give some advantages
> 1. More common ways to adding / running test in Java
> 2. Once CI is setup, junit produces information for CI about details of test.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
