[
https://issues.apache.org/jira/browse/MRUNIT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432165#comment-13432165
]
Dave Beech commented on MRUNIT-138:
-----------------------------------
Brock - You're right of course, but I've always found the difference in
functionality between withInput and withOutput on MapDriver to be confusing and
counter-intuitive. To me the unit test above is pretty concise and clear as to
what should happen. The new methods taking lists are really good, but I've
never liked having to construct Pair objects. Just personal preference, I
guess.
To me, if someone is calling withInput multiple times expecting the input to be
overwritten each time, they're probably trying to do several unit tests inside
one, which is pretty bad news. But yeah - it would break their code. I'm not
sure I want to be the judge as to whether that's a good thing!
> Multiple calls to withInput should be supported
> -----------------------------------------------
>
> Key: MRUNIT-138
> URL: https://issues.apache.org/jira/browse/MRUNIT-138
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Dave Beech
>
> As multiple key/val pairs are now supported for tests following MRUNIT-64, it
> feels to me that I should be able to call withInput multiple times in
> sequence in the same way I would usually call withOutput. This doesn't work
> because of the way the deprecation of the old code has been handled.
> Here's a unit test I think should pass:
> (from TestMapDriver - mapper is IdentityMapper)
> @Test
> public void testMultipleWithInput() throws IOException {
> driver.withInput(new Text("foo"), new Text("bar"))
> .withInput(new Text("bar"), new Text("baz"))
> .withOutput(new Text("foo"), new Text("bar"))
> .withOutput(new Text("bar"), new Text("baz"))
> .runTest(false);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
