[ 
https://issues.apache.org/jira/browse/MRUNIT-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434958#comment-13434958
 ] 

Dave Beech commented on MRUNIT-140:
-----------------------------------

No, I don't think it's necessary to create a new issue for StringUtils, since 
it's all related to reducing the responsibility of TestDriver. If you wanted, 
you could create child issues and link them all to this one but I personally 
wouldn't bother. 

The counter error message correction was completely unrelated, which is why I 
suggested that one should be separate. 
                
> TestDriver should use composition and have less responsilibities
> ----------------------------------------------------------------
>
>                 Key: MRUNIT-140
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-140
>             Project: MRUnit
>          Issue Type: Task
>            Reporter: Bertrand Dechoux
>            Assignee: Bertrand Dechoux
>            Priority: Minor
>         Attachments: mrunit-counter-error-message.diff, 
> mrunit-record-error.diff, mrunit-record-error.patch
>
>
> Due to more and more (welcomed) refactorings, TestDriver is becoming bigger 
> and bigger. Reducing code duplication is a good thing. But TestDriver begins 
> to have too many responsibilities. A solution would be to use composition in 
> order to extract responsibilities from it.
> I currently see a few topics that could profit from it:
> * Errors recording
> * Distributed Cache
> * Counter validation
> You are welcome to suggest more. This work might in the end also help with 
> the implementation of the new API by providing a cleaner internal 
> organisation of MRUnit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to