[
https://issues.apache.org/jira/browse/MRUNIT-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435247#comment-13435247
]
Bertrand Dechoux commented on MRUNIT-140:
-----------------------------------------
I have attempted to refactor distributed cache and validation but the results
is not really worth it.
It moves lines out of TestDriver, sure, but it also adds indirections. It is
not clearly better at the end.
At least, I know now a bit better all the methods (and I cleaned a bit at the
same time : MRUNIT-142).
I think this issue should be closed with the current patch.
And I will look at MRUNIT-139.
> TestDriver should use composition and have less responsilibities
> ----------------------------------------------------------------
>
> Key: MRUNIT-140
> URL: https://issues.apache.org/jira/browse/MRUNIT-140
> Project: MRUnit
> Issue Type: Task
> Reporter: Bertrand Dechoux
> Assignee: Bertrand Dechoux
> Priority: Minor
> Attachments: mrunit-counter-error-message.diff,
> mrunit-record-error.diff, mrunit-record-error.patch
>
>
> Due to more and more (welcomed) refactorings, TestDriver is becoming bigger
> and bigger. Reducing code duplication is a good thing. But TestDriver begins
> to have too many responsibilities. A solution would be to use composition in
> order to extract responsibilities from it.
> I currently see a few topics that could profit from it:
> * Errors recording
> * Distributed Cache
> * Counter validation
> You are welcome to suggest more. This work might in the end also help with
> the implementation of the new API by providing a cleaner internal
> organisation of MRUnit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
