The doc folder doesn't affect the functionality of oneDNN library, so I think it's safe to remove it from the release source package.
BTW, it seems that OFL is on the category B list [1]. I'm curious to know if it is possible to resolve the license issue by adding proper descriptions in LICENSE or DISCLAIMER? [1] https://www.apache.org/legal/resolved.html#weak-copyleft-licenses thanks, -tao On Mon, Feb 22, 2021 at 10:55 AM Sheng Zha <[email protected]> wrote: > In 1.8 release, there was a license issue regarding the font used in > mkldnn/onednn doc, which is currently packaged in mxnet source releases > [1]. I tested locally on a mac that removing 3rdparty/mkldnn/doc doesn't > affect the build so I suggest we simply remove it during release. > > [1] > https://lists.apache.org/thread.html/rf809c7b700d4523f73f8b376ce106719fbf000eff898b5ed8e97b486%40%3Cgeneral.incubator.apache.org%3E > > Thanks, > Sheng > > On 2021/02/18 03:58:14, Wei Chu <[email protected]> wrote: > > Thank you Sheng for the info. I'll update this item on runbook > accordingly. > > > > Best, > > Wei > > > > On 2021/02/18 01:27:58, Sheng Zha <[email protected]> wrote: > > > I can comment on the second item. > > > > > > > Similarly, we have a step for <Ensure that PR verification is > enabled for the target release branch> in the runbook. This step has not > been executed after MXNet 1.4 release: > https://jenkins.mxnet-ci.amazon-ml.com/job/incubator-mxnet/. > > > > > > The branch protection is enabled for all release branches based on the > name regex in INFRA-20471 [1] so that it doesn't require manual setting as > long as the naming convention is kept. > > > > > > Thanks, > > > Sheng > > > > > > [1] https://issues.apache.org/jira/browse/INFRA-20471 > > > > > > On 2021/02/17 23:53:18, Wei Chu <[email protected]> wrote: > > > > Hi dev community, > > > > > > > > In the MXNet release runbook, we have a step for <Backward > Compatibility checker>: > https://cwiki.apache.org/confluence/display/MXNET/Release+Process#ReleaseProcess-NightlyTests > > > > This step is a part of the nightly test pipeline and it's been > failing in the past 11 months: > https://jenkins.mxnet-ci.amazon-ml.com/view/Nightly%20Tests/ > > > > > > > > Similarly, we have a step for <Ensure that PR verification is > enabled for the target release branch> in the runbook. This step has not > been executed after MXNet 1.4 release: > https://jenkins.mxnet-ci.amazon-ml.com/job/incubator-mxnet/. > > > > > > > > I am wondering if these two steps are still needed? If not, can we > consider to remove them from the runbook? > > > > > > > > Best, > > > > Wei > > > > > > > > > > > > > >
