Just tested with 1.3.0 and those tests were failing for that release as well. Given it's not a regression I'm +1 (non-binding).
On Thu, Nov 15, 2018 at 11:52 PM kellen sunderland < kellen.sunderl...@gmail.com> wrote: > Thanks for organizing the release Anton and for testing Carin and > Steffen. Lots of great fixes in this release. As we don't have the > required 3 committers I'd suggest extending the vote for a few days. > > I tested the following on MacOS 10.13, High Sierra: > > INCUBATING IN RELEASE FILE: check. > LICENSE check. > NOTICE check. > SIGNATURE check. > HASH check. > DISCLAIMER check. > SOURCE COMPILES VIA MAKEFILE check. > SOURCE COMPILES VIA CMAKE check. > C++ TESTS PASS fail > Two tests failing for me. > Build with flags: cmake -DUSE_CUDA=0 -DUSE_CUDNN=0 -DUSE_OPENMP=0 > -DUSE_OPENCV=0 .. > Ran c++ tests with exclusions: ./tests/mxnet_unit_tests > --gtest_filter=-GpuTopology.* > Result: > [ FAILED ] 2 tests, listed below: > [ FAILED ] ACTIVATION_PERF.ExecuteBidirectional > [ FAILED ] ACTIVATION_PERF.TimingCPU > > PYHTON UNIT TESTS PASS check. > > Not sure if the test failures are a regression so I'm +0 (non-binding) > > On Thu, Nov 15, 2018 at 5:43 PM Steffen Rochel <steffenroc...@gmail.com> > wrote: > >> +1 build on MacOS Sierra following instructions on >> >> https://cwiki.apache.org/confluence/display/MXNET/MXNet+Developer+Setup+on+Mac >> and run one training test. >> >> On Tue, Nov 13, 2018 at 2:34 PM Carin Meier <carinme...@gmail.com> wrote: >> >> > +1 - Clojure package tested fine with Scala jars >> > >> > On Mon, Nov 12, 2018 at 6:53 PM Anton Chernov <mecher...@gmail.com> >> wrote: >> > >> > > Dear MXNet community, >> > > >> > > This is the vote to release Apache MXNet (incubating) version 1.3.1. >> > Voting >> > > will start now, on Monday the 12th of November 2018 and close on 14:00 >> > > Thursday the 15th of November 2018, Pacific Time (PT). >> > > >> > > Link to release notes: >> > > https://cwiki.apache.org/confluence/x/eZGzBQ >> > > >> > > Link to release candidate 1.3.1.rc0: >> > > https://github.com/apache/incubator-mxnet/releases/tag/1.3.1.rc0 >> > > >> > > Link to source and signatures on apache dist server: >> > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.3.1.rc0/ >> > > >> > > Link to scala packages on the staging repo: >> > > >> > > * CPU >> > > >> > > >> > >> https://repository.apache.org/content/repositories/snapshots/org/apache/mxnet/mxnet-full_2.11-osx-x86_64-cpu/1.3.1-SNAPSHOT/ >> > > >> > > * GPU >> > > >> > > >> > >> https://repository.apache.org/content/repositories/snapshots/org/apache/mxnet/mxnet-full_2.11-linux-x86_64-gpu/1.3.1-SNAPSHOT/ >> > > >> > > Please remember to TEST first before voting accordingly: >> > > +1 = approve >> > > +0 = no opinion >> > > -1 = disapprove (provide reason) >> > > >> > > >> > > Best regards, >> > > Anton >> > > >> > >> >
