Sean Schofield wrote:
IMO that is NOT a blocker for the 1.1.1 release. There are lots of little issues with Tomahawk components. If we waited to get every last one done we would never release. The main thing is to get this out so we can fix the problem with myfaces-all.jar in 1.1.0 (a legitimate blocker.)
This is a change in a "patch release" (1.1.0 -> 1.1.1) which breaks backwards compatibility.
Any jakarta commons project would consider this a blocker issue. I (as a commons committer) would certainly veto any commons library release with such a change in it. Any commons component can be upgraded from 1.1.x to 1.1.y with confidence that no valid code will stop working, and I believe that is a reasonable expectation.
The change to jscookMenu, however, will break every application out there that uses a custom theme; there was only one way to implement a custom theme up until now (AFAIK) and changes made since 1.1.0 now cause that approach to throw an exception. The patch that was applied to TRUNK ensures that code that used to work will still work.
Note that this is not an issue I personally care about; I'm currently on 1.1.0 and am likely to move direct to TRUNK soon as there is some good stuff there which has (correctly) not been put into the 1.1.1 "bugfix" branch.
Regards, Simon
