On Jan 30, 2008 9:06 PM, Bruno Aranda <[EMAIL PROTECTED]> wrote: > I am with Matthias as whether to checkin in generated files or not. My > personal experience tells that adding generated files under subversion > makes the project more difficult to maintain, because you have to be > even more aware of how the code generation works. For instance, you > have to remove manually from the repository those sources that are not > generated anymore, deal with far more merges - regenerating classes > that already exist could mean unnecessary merges if you modify first
+1 ! > your class. Even if you don't like the templates (I do) I would rather > not check the generated stuff. likely > And, of course, you have to be aware not to modify whatever it is > autogenerated below the "Do not edit from here" as we did for the > first generator. Temptation always lead to modify stuff in that yup > sections, on purpose or by mistake, and your changes lost... or a > conflict... i know it is a worst case scenario, but if it can happen, > it will happen.. :-) > > Cheers, > > Bruno > > > On 30/01/2008, Mario Ivankovits <[EMAIL PROTECTED]> wrote: > > Hi! > > > 1) we do an abstract component base class, very clean, however, it > > > will not work for MyFaces-AP > > > I personally think we can go with option 1 only - there are not so > > > many API classes, and changes in the API are not ocurring too often. > > > > > +1 > > I have no problems if this does not work with the API stuff, even if > > another solution would be great, this is the best we can get given our > > all time constraints. > > > > As you said, anything else will allow us to work in a normal way with > > our IDEs. > > > > If it fits your needs, I also do not care if we checkin the generated > > files. But then, it is required that mvn eclipse:eclipse and mvn > > idea:idea correctly generate the files first and then adds them as > > additional source to the project. Probably this is possible. > > Said that, the question is what we would like to see in SVN. Some xml > > file changes where we do not know how they get woven into the generated > > files, or a well known svn history. > > So, from my current point of view I'd vote to checkin the generated > > files too. > > > > Ciao, > > Mario > > > > > -- Matthias Wessendorf further stuff: blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf mail: matzew-at-apache-dot-org
