Generally I really do agree with Simon that "a simple, serious redesign
of every component would probably do better than hooks".
Also, I really think once you put restrictions on your renderers you run
into issues, like you have a bug or a new feature which makes you need
to reorganize in an unexpected way. I'm fine with making it easier to
subclass renderers for those that want to take the risk, but I'm -1 on
any scheme that restricts our ability to make changes when the need arises.
Other comments inline:
Andrew Robinson wrote:
Could we move this discussion away from a debate?
Could MyFaces Committers or PMC members _only_ please share their
thoughts on this to keep the discussion to the stake holders only?
Please share other solutions as you have them.
Here some view points to discuss:
1) remove the restriction of trinidad-impl being non-API and enforce
that code in this package be backward-compatible
-1, the renderers have to be able to change without worrying about
backwards compatibility.
2) somehow move some of the burden of parts of renderers out of
trinidad-impl and into trinidad-api
Maybe I've misunderstood, but this sounds like it's basically the same
as 1 but for pieces of a renderer, -1.
3) introduce some configurable way to override default behavior for
rendering certain areas of components.
That would be fine, as long as there's not a perf issue, and there's an
understanding that things may break at the next release - hopefully
rare, but possible.
4) removing some final modifiers after discussion and make extending
Trinidad renderers accepted, aka not tabu
I think removing final modifiers AFTER discussion is fine, and I think
if people want to risk extending renderers then fine, but we make no
promises they will not break at the next release. Same for 5 below.
Thanks,
Gab
5) promoting private members to protected or public after discussion
and make extending Trinidad renderers accepted, aka not tabu
Christi, could you please share more of your needs and give further
legitimate reasons why this is needed?
If you are not a member of MyFaces, Committer or PMC member please
refrain from further reply to this thread as your feedback has already
been noted.
Thank you,
Andrew
On Wed, Apr 9, 2008 at 6:23 PM, Cristi Toth <[EMAIL PROTECTED]> wrote:
Hi guys,
A lot of Trinidad renderers have some "override useful" methods as private
or protected final.
This makes customizing renderers a nasty job.
- first these methods obviously can't be overriden
- then when trying to override some public/protected methods,
it's hard because they use other private methods that you can't use in
your overriden method
I assume this come from the fact that Trinidad wasn't open-source in its
origins... or?
Do we still have reasons to keep it this way?
IMO we could make those protected final "override useful" methods to
protected
and the private methods used in those methods, make them protected final.
What's you opinion on this?
Regards,
--
Cristi Toth
-------------
Codebeat
www.codebeat.ro