+1 (both points)
2008/6/4 Leonardo Uribe <[EMAIL PROTECTED]>: > +1 > > On Tue, Jun 3, 2008 at 10:55 PM, Leonardo Uribe <[EMAIL PROTECTED]> wrote: >> >> Hi >> >> The code necessary to tomahawk 1.2 is ready for commit. >> >> For do this, it is necessary to apply myfaces builder plugin on myfaces >> core 1.2. The work on myfaces core 1.2 can be seen here: >> >> >> http://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/branches/builder_plugin/bigtest/core_trunk_1.2.x/ >> >> There is still some details that I'm solving (I want to remove >> myfaces-faces-plugin, and generate everything with myfaces-builder-plugin), >> but the code is ready for a vote. It uses source annotations (instead >> doclets on 1.1, see myfaces-builder-annotations submodule). For do this >> first it was modified temporally myfaces-faces-plugin for generate >> myfaces-builder-annotations automatically and then do the upgrade (and add >> additional missing info). Clirr report does not show any problems. >> >> The code for tomahawk 1.2 can be seen here >> >> >> http://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/branches/builder_plugin/bigtest/tomahawk12_trunk/ >> >> It uses the new unpack mojo that makes very easy the maintain of this >> project. The idea of unpack goal is extract tomahawk 1.1 parts of code and >> resources automatically, making this project relatively small. >> >> In conclusion, the vote is for this parts: >> >> 1. Apply myfaces-builder-plugin on myfaces core 1.2 (necessary for build >> correct myfaces-metadata.xml for tomahawk 1.2) >> 2. Add two modules called core12 and sandbox/core12 on tomahawk, that >> contains 1.2 specific code for tomahawk. >> >> Suggestions are welcome. >> >> regards >> >> Leonardo Uribe >> >> >> > >