Isn't Tomahawk already a commons set of components? It works with other render kits, besides some incompatibilities do to the filter design. I am wondering if we are attempting to put too much into commons.
My take would be if this is a component that does any rendering it fits well in Tomahawk, but if it is more of a framework feature, then commons would be better. +0 for me though, I don't mind either approach, I'll let others decide. On Fri, Jun 6, 2008 at 6:38 AM, Hazem Saleh <[EMAIL PROTECTED]> wrote: > I have no problem to give non Tomahawk users the ability to use the > exporter, but I would like to use the nice Tomahawk features so that the > component can be more useful and prettier (Please wait till I show you a > near demo about the exporter and you will get my point). > > On Fri, Jun 6, 2008 at 3:30 PM, Matthias Wessendorf <[EMAIL PROTECTED]> > wrote: >> >> On Fri, Jun 6, 2008 at 2:28 PM, Volker Weber <[EMAIL PROTECTED]> wrote: >> > Hi Hazem, >> > >> > there is no reason why tomahawk should not depends on common-*. >> > >> > If you have a well working UIData content to exel/pdf exporter why >> > don't give non tomahawk users the ability to use it. >> >> that were exactly my reasons. >> even more, the application would require the extra commons-* stuff, >> when one want the exporter. >> >> > >> > >> > Regards, >> > Volker >> > >> > 2008/6/6 Hazem Saleh <[EMAIL PROTECTED]>: >> >> Hi Team, >> >> >> >> I will suspend this vote for now. >> >> I will start now implementing some of my future work of this component >> >> so >> >> that no confusion can be occur. >> >> I will be back to this thread after showing you a concrete example. >> >> Thanks all very much. >> >> >> >> On Fri, Jun 6, 2008 at 2:41 PM, Hazem Saleh <[EMAIL PROTECTED]> wrote: >> >>> >> >>> As I said before, This listener will be aware of other Tomahawk >> >>> components >> >>> (The current functionality will be extended). >> >>> BTW, I don't think that I said some thing so funny! >> >>> >> >>> On Fri, Jun 6, 2008 at 2:10 PM, Matthias Wessendorf >> >>> <[EMAIL PROTECTED]> >> >>> wrote: >> >>>> >> >>>> On Fri, Jun 6, 2008 at 12:58 PM, Hazem Saleh <[EMAIL PROTECTED]> >> >>>> wrote: >> >>>> > I still totally agree with Leonardo, Iam not seeing that Tomahawk >> >>>> > should >> >>>> > depend on myfaces-commons to use the exporterListener component. >> >>>> >> >>>> lol >> >>>> there would be no dependency... >> >>>> in an ideal world such a listener is totally independent from the >> >>>> used >> >>>> table >> >>>> (icefaces, tomahawk, standard, ...) >> >>>> >> >>>> So, just add it to the page (inside an actionsource(2)) and refer to >> >>>> the >> >>>> desired >> >>>> table. I can't see why that way such an exporter would have a >> >>>> dependency >> >>>> to >> >>>> tomahawk. >> >>>> >> >>>> > Iam still (+1). >> >>>> > >> >>>> > On Fri, Jun 6, 2008 at 3:53 AM, Leonardo Uribe <[EMAIL PROTECTED]> >> >>>> > wrote: >> >>>> >> >> >>>> >> The actual layout of myfaces-commons is this: >> >>>> >> >> >>>> >> myfaces-commons-validators >> >>>> >> myfaces-commons-converters >> >>>> >> myfaces-commons-utils >> >>>> >> >> >>>> >> There is no a project like: >> >>>> >> >> >>>> >> myfaces-commons-listeners >> >>>> >> >> >>>> >> myfaces-commons is tied to 1.2, so if some converter or validator >> >>>> >> is >> >>>> >> in >> >>>> >> tomahawk 1.1, on tomahawk 1.2 this should be referred to >> >>>> >> myfaces-commons >> >>>> >> (makes easy for existing tomahawk user upgrade and do not change >> >>>> >> their >> >>>> >> current pages). In this case myfaces-commons should be a >> >>>> >> dependency >> >>>> >> for >> >>>> >> tomahawk. >> >>>> >> >> >>>> >> According to the intention of several developers, there are things >> >>>> >> of >> >>>> >> tomahawk that it should be on its own submodule (dojo components >> >>>> >> by >> >>>> >> example, >> >>>> >> converters and validators) and others in tomahawk. This issues >> >>>> >> were >> >>>> >> not be >> >>>> >> discussed yet, so if this is in tomahawk there is no prob. >> >>>> >> >> >>>> >> +1 >> >>>> >> >> >>>> >> regards >> >>>> >> >> >>>> >> Leonardo Uribe >> >>>> >> >> >>>> >> On Thu, Jun 5, 2008 at 6:50 PM, Hazem Saleh <[EMAIL PROTECTED]> >> >>>> >> wrote: >> >>>> >>> >> >>>> >>> Hi Volker, >> >>>> >>> >> >>>> >>> I have a future plan of extending the functionality of this >> >>>> >>> component >> >>>> >>> to >> >>>> >>> make it aware of the current displayed Tomahawk dataTable page. >> >>>> >>> I mean, the generated reports will be aware of Tomahawk related >> >>>> >>> classes. >> >>>> >>> Thanks. >> >>>> >>> >> >>>> >>> On Thu, Jun 5, 2008 at 6:14 PM, Volker Weber <[EMAIL PROTECTED]> >> >>>> >>> wrote: >> >>>> >>>> >> >>>> >>>> Hi, >> >>>> >>>> >> >>>> >>>> any reason to move this to tomahawk and not into commons? >> >>>> >>>> >> >>>> >>>> Are there any dependencies to tomahawk or a specific renderkit? >> >>>> >>>> >> >>>> >>>> I had not looked into, but if this is what it sounds like : >> >>>> >>>> A actionListener which could added to any UICommand component, >> >>>> >>>> which renders binary data from a UIData component, >> >>>> >>>> than there is no reason to add this to a html-renderkit library. >> >>>> >>>> >> >>>> >>>> -1 in this case for tomahawk. >> >>>> >>>> -0 otherwise >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> Regards, >> >>>> >>>> Volker >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> 2008/6/5 Hazem Saleh <[EMAIL PROTECTED]>: >> >>>> >>>> > Hi Team, >> >>>> >>>> > >> >>>> >>>> > After integration the pdfExport and the excelExport components >> >>>> >>>> > into >> >>>> >>>> > the >> >>>> >>>> > exporterActionListener component, >> >>>> >>>> > improving its syntax and completing its documentation. >> >>>> >>>> > >> >>>> >>>> > I wish to promote this component to the next Tomahawk release. >> >>>> >>>> > >> >>>> >>>> > [+1] for agreeing with promoting the component to the next >> >>>> >>>> > Tomahawk >> >>>> >>>> > release. >> >>>> >>>> > [-1] for disagreeing with promoting the component to the next >> >>>> >>>> > Tomahawk >> >>>> >>>> > release. >> >>>> >>>> > >> >>>> >>>> > Thanks all very much! >> >>>> >>>> > >> >>>> >>>> > -- >> >>>> >>>> > Hazem Ahmed Saleh Ahmed >> >>>> >>>> > http://www.jroller.com/page/HazemBlog >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> -- >> >>>> >>>> inexso - information exchange solutions GmbH >> >>>> >>>> Bismarckstraße 13 | 26122 Oldenburg >> >>>> >>>> Tel.: +49 441 4082 356 | >> >>>> >>>> FAX: +49 441 4082 355 | www.inexso.de >> >>>> >>> >> >>>> >>> >> >>>> >>> >> >>>> >>> -- >> >>>> >>> Hazem Ahmed Saleh Ahmed >> >>>> >>> http://www.jroller.com/page/HazemBlog >> >>>> > >> >>>> > >> >>>> > >> >>>> > -- >> >>>> > Hazem Ahmed Saleh Ahmed >> >>>> > http://www.jroller.com/page/HazemBlog >> >>>> >> >>>> >> >>>> >> >>>> -- >> >>>> Matthias Wessendorf >> >>>> >> >>>> further stuff: >> >>>> blog: http://matthiaswessendorf.wordpress.com/ >> >>>> sessions: http://www.slideshare.net/mwessendorf >> >>>> mail: matzew-at-apache-dot-org >> >>> >> >>> >> >>> >> >>> -- >> >>> Hazem Ahmed Saleh Ahmed >> >>> http://www.jroller.com/page/HazemBlog >> >> >> >> >> >> -- >> >> Hazem Ahmed Saleh Ahmed >> >> http://www.jroller.com/page/HazemBlog >> > >> > >> > >> > -- >> > inexso - information exchange solutions GmbH >> > Bismarckstraße 13 | 26122 Oldenburg >> > Tel.: +49 441 4082 356 | >> > FAX: +49 441 4082 355 | www.inexso.de >> > >> >> >> >> -- >> Matthias Wessendorf >> >> further stuff: >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> mail: matzew-at-apache-dot-org > > > > -- > Hazem Ahmed Saleh Ahmed > http://www.jroller.com/page/HazemBlog