On Sat, Sep 6, 2008 at 8:50 AM, Bernd Bohmann <[EMAIL PROTECTED]> wrote: > Hello, > > just created issue TRINIDAD-1220. > > Can I commit the module to > > http://svn.apache.org/repos/asf/myfaces/trinidad/trunk_1.2.x/trinidad-partial-lifecycle?
that is fine, to me... (please don't add it to the default build process ;-) ) -M > > The example patch for trinidad impl is attached to the issue. > > Regards > > Bernd > > Matthias Wessendorf schrieb: >> I spoke a bit with Bernd about this on the phone. >> I'd love to see this happen. >> >> Bernd, can you just create an artifact that we can review this ? >> Or is it possible that you create an issue in JIRA and you attach >> the patch and lifecycle + factory ? >> >> -M >> >> On Sat, Sep 6, 2008 at 6:53 AM, Bernd Bohmann <[EMAIL PROTECTED]> wrote: >>> >>> Bernd Bohmann schrieb: >>>>> Also, is there any real way we can take a look at the code before it's >>>>> committed? Maybe move it to the sandbox first so people can take a more >>>>> detailed look at it? >>>> I would prefer a commit and review policy. I think it should not part of >>>> the sandbox. The new artifact don't need api, imp... it's only a jar >>>> with a LifecycleFactory. I can add the trinidad-partial-lifecycle module >>>> under >>>> >>>> http://svn.apache.org/repos/asf/myfaces/trinidad/trunk_1.2.x/ >>>> >>>> or >>>> >>>> http://svn.apache.org/repos/asf/myfaces/trinidad/trunk_1.2.x/trinidad-sandbox/ >>> For the changes in trindad-impl I would prefer a review and commit >>> policy, maybe there is a better option for the changes. >>> >>> >>> Regards >>> >>> Bernd >>> >> >> >> > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf