Hello, I now applied Max's patch to Trinidad 2.0.0 branch ([1]).
Have fun! -Matthias [1] https://svn.apache.org/repos/asf/myfaces/trinidad/branches/trinidad-2.0.x On Mon, Oct 12, 2009 at 6:48 AM, Max Starets <max.star...@oracle.com> wrote: > Martin, > > Martin Kočí wrote: > > Hi, > > why I asked about partial state saving is compile-time dependency on > facelets 1.1.X in TrinidadComponentHandler and StateManagerImpl, both on > PARAM_BUILD_BEFORE_RESTORE param. With mojarra 2 jsf-impl and facelets > 1.1.x cannot be deployed concurrently. > > > This code will be commented out in my patch. It will all be sorted out when > we integrate Trinidad's partial state > saving with JSF 2.0. > > Few thoughts on facelets2 and trinidad2 : > > - change tr.taglib.xml and trh.taglib.xml root element (generated with > maven plugin?) to: > > <facelet-taglib xmlns="http://java.sun.com/xml/ns/javaee" > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > xsi:schemaLocation="http://java.sun.com/xml/ns/javaee > http://java.sun.com/xml/ns/javaee/web-facelettaglibary_2_0.xsd" > version="2.0"> > > - rewrite TrinidadFaceletViewHandler (if it is still needed) to > ViewDefinitionLanguage > > > It is going away. > > - drop old facelets code from TrinidadComponentHandler, > StateManagerImpl and TrinidadListenersTagRule and dependency from > pom.xml > > - and sure more but I'm not familiar with facelets > > > Regards, > > Martin Koci > > > Max Starets píše v Pá 09. 10. 2009 v 16:50 -0400: > > > Martin, > > I agree we should look at integrating JSF 2.0 partial state saving into > Trinidad seamlessly. > It would not jump to conclusions about FaceBean just yet though. > > I am currently working on getting the branch to compile and run with JSF > 2.0 (pretty much along the lines > that you were suggesting in your previous e-mail). > > I will enter a JIRA for that and submit a patch probably on Monday. Once > we get to a point where we can build > and test, we should start looking at features like partial state saving. > > Regards, > Max Starets > > Martin Koc(í wrote: > > > Hi, > > for Trinidad2: should we deprecate FacesBean and use StateHelper > instead? I think it is the same idea: > > http://myfaces.apache.org/trinidad/trinidad-api/apidocs/org/apache/myfaces/trinidad/bean/FacesBean.html > > https://javaserverfaces.dev.java.net/nonav/docs/2.0/javadocs/javax/faces/component/StateHelper.html > https://javaserverfaces.dev.java.net/nonav/docs/2.0/javadocs/javax/faces/component/PartialStateHolder.html > > Concept is related to state saving and I think we should force Trinidad2 > to use partial state saving from JSF 2.0 because that was inspired by > trinidad. Am I right? > > > Martin > > > > > > > > > > > > > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf