On Fri, Dec 11, 2009 at 4:40 PM, Simon Lessard <simon.lessar...@gmail.com> wrote: > Looks good to me as well. I've got to admit that this ProjectStage thing > seems to get more useful than what I was thinking when I first saw it pop on > the EG list
+1 same here :-) I love the feature now :-) > > On Thu, Dec 10, 2009 at 1:12 PM, Matthias Wessendorf <mat...@apache.org> > wrote: >> >> awesome. >> >> I plan to start development on that next week... Till than you can >> change your mind :-) >> >> -Matthias >> >> On Thu, Dec 10, 2009 at 7:08 PM, Jeanne Waldman >> <jeanne.wald...@oracle.com> wrote: >> > I agree with your list Matthias. >> > Jeanne >> > >> > Matthias Wessendorf wrote, On 12/8/2009 8:56 AM PT: >> > >> > http://wiki.apache.org/myfaces/Trinidad_goes_ProjectStage >> > >> > On Tue, Dec 8, 2009 at 5:54 PM, Matthias Wessendorf <mat...@apache.org> >> > wrote: >> > >> > >> > ok, >> > >> > I updated the wiki: >> > >> > I will continue with these values, as there was no concern against them. >> > >> > regarding the hidden, unspecified >> > "javax.faces.FACELETS_REFRESH_PERIOD" parameter, I will follow up in >> > a different thread. >> > >> > -Matthias >> > >> > On Wed, Dec 2, 2009 at 9:06 PM, Matthias Wessendorf <mat...@apache.org> >> > wrote: >> > >> > >> > On Wed, Dec 2, 2009 at 8:52 PM, Pavitra Subramaniam >> > <pavitra.subraman...@oracle.com> wrote: >> > >> > >> > "Matthias Wessendorf wrote:" On 12/2/2009 10:43 AM PT: >> > >> > Ok, >> > >> > I added some value suggestions to those guys that we identified to fit >> > into the ProjectStage API: >> > >> > >> > -org.apache.myfaces.trinidad.DEBUG_JAVASCRIPT >> > * Production => FALSE >> > * other stages => TRUE >> > >> > >> > +1. although I think if a user were to change the recommended defaults, >> > like >> > set ProjectStage=Production and override the DEBUG_JS to be true, then >> > we at >> > least need to warn the user of this as appropriate. >> > >> > >> > Yeah I was planing do WARNING for everything that is overridden >> > >> > >> > >> > -org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION >> > * Production => FALSE >> > * other stages => TRUE >> > -org.apache.myfaces.trinidad.CHECK_FILE_MODIFICATION >> > * Production => FALSE >> > * other stages => TRUE >> > -org.apache.myfaces.trinidad.resource.DEBUG >> > * Production => FALSE >> > * other stages => TRUE >> > -org.apache.myfaces.trinidadinternal.ENABLE_PPR_OPTIMIZATION (see above) >> > * Production => FALSE (current default) >> > * other stages => TRUE >> > -<debug-output> (from trinidad-config.xml file) >> > * Production => FALSE >> > * other stages => TRUE >> > >> > >> > +1. I also was wondering if >> > "org.apache.myfaces.trinidad.CHECK_STATE_SERIALIZATION" should be set to >> > NONE in Production if this is really used for a testing Trinidad in >> > pseudo-High Availability (HA) mode. It looks like we could set this >> > different values based on the the ProjectStage >> > >> > Production >> > org.apache.myfaces.trinidad.CHECK_STATE_SERIALIZATION=none >> > >> > Development, Unit Test >> > org.apache.myfaces.trinidad.CHECK_STATE_SERIALIZATION=session,tree >> > >> > System Test >> > org.apache.myfaces.trinidad.CHECK_STATE_SERIALIZATION=all >> > >> > >> > great. thanks for the feedback. Makes sense to me. I think that this >> > parameter actually *translates* to the ProjectStage. >> > Your suggestions make sense to me. >> > >> > -Matthias >> > >> > >> > >> > >> > -Pavitra >> > >> > Please let me know what you think... >> > >> > >> > I updated the wiki page, to reflect the suggestions: >> > http://wiki.apache.org/myfaces/Trinidad_goes_ProjectStage >> > >> > I also created this JIRA ticket, to keep track of the item: >> > https://issues.apache.org/jira/browse/TRINIDAD-1652 >> > >> > -Matthias >> > >> > On Wed, Dec 2, 2009 at 3:18 PM, Matthias Wessendorf <mat...@apache.org> >> > wrote: >> > >> > >> > yep, that's what I was saying >> > >> > On Wed, Dec 2, 2009 at 3:04 PM, Jakob Korherr <jakob.korh...@gmail.com> >> > wrote: >> > >> > >> > Hi, >> > >> > I think the best way would be that the init parameters have stage >> > related >> > standard values (actually that what Matthias suggested), for example: >> > >> > If we are in ProjectStage.Production the standard value of >> > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION is false, >> > otherwise >> > it is true. >> > >> > But this only sets the DEFAULT value. The user still can configure each >> > parameter independently by putting it in web.xml. >> > >> > Regards >> > >> > Jakob Korherr >> > >> > 2009/12/2 Martin Koci <martin.k...@aura.cz> >> > >> > >> > Hi, >> > >> > does trinidad reload both JSP and facelets views if >> > org.apache.myfaces.trinidad.CHECK_FILE_MODIFICATION=true? >> > >> > For facelets based views there is a new JSF 2.0 param >> > javax.faces.FACELETS_REFRESH_PERIOD (-1 = never reload, 0=always, 1,2, >> > 3,.. - check interval) but it's relation to project stage is not clear - >> > see https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1434 >> > >> > Martin Kočí >> > >> > Matthias Wessendorf píše v St 02. 12. 2009 v 09:25 +0100: >> > >> > >> > Hi, >> > >> > here is a (complete?) list of all Trinidad configuration parameters: >> > >> > * System Properties ( => System.getProperty(....)): >> > org.apache.myfaces.trinidad.CHECK_STATE_SERIALIZATION >> > documentation is here: >> > http://issues.apache.org/jira/browse/TRINIDAD-1245 >> > >> > >> > http://myfaces.apache.org/trinidad/trinidad-api/apidocs/org/apache/myfaces/trinidad/bean/util/StateUtils.html >> > >> > ==> does not really make sense to port to Stage..... >> > >> > * The "trinidad-config.xml" file: >> > See here for infos about it: >> > http://myfaces.apache.org/trinidad/devguide/configuration.html >> > >> > I think that ONLY this element could make sense: >> > -<debug-output> >> > (e.g. as for PRODUCTION you want FALSE here... ) >> > >> > * Settings in the WEB.XML (aka Context Parameters): >> > Some info is here as well: >> > http://myfaces.apache.org/trinidad/devguide/configuration.html >> > >> > The web.xml has different types of settings: >> > some fit to ProjectStage, some not...... >> > >> > Here is a grouped list, where I think they don't make sense with >> > project_stage at all: >> > -org.apache.myfaces.trinidad.CACHE_VIEW_ROOT >> > -org.apache.myfaces.trinidad.CLIENT_STATE_METHOD >> > -org.apache.myfaces.trinidad.CLIENT_STATE_MAX_TOKENS >> > -org.apache.myfaces.trinidad.CHANGE_PERSISTENCE >> > -org.apache.myfaces.trinidad.USE_APPLICATION_VIEW_CACHE >> > -org.apache.myfaces.trinidad.ENABLE_LIGHTWEIGHT_DIALOGS >> > -org.apache.myfaces.trinidad.ALTERNATE_VIEW_HANDLER >> > -org.apache.myfaces.trinidad.FACELETS_VIEW_MAPPINGS >> > -org.apache.myfaces.trinidad.UPLOAD_MAX_MEMORY >> > -org.apache.myfaces.trinidad.UPLOAD_MAX_DISK_SPACE >> > -org.apache.myfaces.trinidad.UPLOAD_TEMP_DIR >> > >> > These parameters do make sense: >> > -org.apache.myfaces.trinidad.DEBUG_JAVASCRIPT >> > -org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION >> > -org.apache.myfaces.trinidad.CHECK_FILE_MODIFICATION >> > -org.apache.myfaces.trinidad.resource.DEBUG >> > (note, we need a bug here, as this is NOT documented in the "official >> > documentation" :-) ) >> > >> > This parameter _may_ make sense (*caution:* it is an internal and >> > temporary param): >> > -org.apache.myfaces.trinidadinternal.ENABLE_PPR_OPTIMIZATION >> > See http://issues.apache.org/jira/browse/TRINIDAD-1368 >> > >> > So basically, only these make sense (for me): >> > -org.apache.myfaces.trinidad.DEBUG_JAVASCRIPT >> > -org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION >> > -org.apache.myfaces.trinidad.CHECK_FILE_MODIFICATION >> > -org.apache.myfaces.trinidad.resource.DEBUG >> > -org.apache.myfaces.trinidadinternal.ENABLE_PPR_OPTIMIZATION (*see >> > above) >> > -<debug-output> >> > >> > Let me know if you agree with this list and I will follow up on what >> > values they should have, >> > in what STAGE.... >> > >> > A note: Perhaps we want to be able to still override a _SINGLE_ >> > setting, regardless for the >> > current STAGE. Means: If the application runs in >> > "ProjectStage.Production", we do CSS compression. >> > BUT... if the web.xml says >> > "org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION => TRUE", >> > we should honor that... This would give users a more fine grained >> > control over these configuration settings. >> > >> > What do you think ? >> > >> > Greetings, >> > Matthias >> > >> > >> > >> > >> > >> > >> > >> > >> > -- >> > Matthias Wessendorf >> > >> > blog: http://matthiaswessendorf.wordpress.com/ >> > sessions: http://www.slideshare.net/mwessendorf >> > twitter: http://twitter.com/mwessendorf >> > >> > >> > >> > >> > >> > >> > -- >> > Matthias Wessendorf >> > >> > blog: http://matthiaswessendorf.wordpress.com/ >> > sessions: http://www.slideshare.net/mwessendorf >> > twitter: http://twitter.com/mwessendorf >> > >> > >> > >> > -- >> > Matthias Wessendorf >> > >> > blog: http://matthiaswessendorf.wordpress.com/ >> > sessions: http://www.slideshare.net/mwessendorf >> > twitter: http://twitter.com/mwessendorf >> > >> > >> > >> > >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf > > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf