Hi Leonardo, Your response triggered me to read the JavaDocs again from your point of view. It looks like the spec is not very clear on this.
I've commented on the issue in JIRA, as follows: ++++++++++++++++++++++++++++++++++++ Hrm, it looks like the JavaDoc can be interpreted in multiple ways. What I read, is that it should be possible for classes that implement SystemEventListener, to listen to SystemEvents. For example: http://java.sun.com/javaee/javaserverfaces/2.0/docs/api/javax/faces/event/PostConstructApplicationEvent.html The current implementation cannot deal with this event, because it occurs before the ApplicationImpl code is invoked (there is no component tree at that time). For this reason, we need to check it @startup. But because its so ambiguous, I suggest to leave it out of the beta release. ++++++++++++++++++++++++++++++++++++ I would say, let's keep it out of this release... :-) Regards, Jan-Kees 2010/1/26 Jan-Kees van Andel <jankeesvanan...@gmail.com>: > Not entirely true, there are two types of events that need to be > processed. ApplicationImpl handles only one of them (the component > system events). These are registered on a component. The patch > provides support for the other type: global system events. These are > registered by invoking Appliaction.subscribeToEvent. > > But I don't think it's important enough to delay the release. > > Regards, > Jan-Kees > > > 2010/1/26 Leonardo Uribe <lu4...@gmail.com>: >> Hi >> >> About @ListenerFor: It is working as expected. I don't think the patch >> provided will work, because this annotation is handled on ApplicationImpl >> (because the annotations must be read when the component/renderer is >> created). >> >> About MYFACES-2356 (decode behavior for UISelectOne components): I did >> another patch that implements the change proposed on the renderkitdoc. >> Michael, could you try if this patch works as expected? If so, I'll restart >> the vote. >> >> regards, >> >> Leonardo Uribe >> >> 2010/1/25 Jan-Kees van Andel <jankeesvanan...@gmail.com> >>> >>> Hi Leonardo, >>> >>> Are you gonna rebuild now? I just submitted a patch with support for >>> the @ListenerFor/@ListenersFor annotations to handle global system >>> events. >>> >>> See MYFACES-2509 >>> >>> I'm quite sure it doesn't break anything, but I don't want to >>> introduce any risks short before the beta release so if someone can >>> review the patch we might be able to include it... >>> >>> Regards, >>> Jan-Kees >>> >>> >>> 2010/1/25 Leonardo Uribe <lu4...@gmail.com>: >>> > Ok, I'll commit that patch on the branch, rebuild all artifacts and ask >>> > for >>> > a vote again. Thanks for the information. >>> > >>> > 2010/1/25 Michael Kurz <michi.k...@gmx.at> >>> >> >>> >> -1 >>> >> >>> >> I have to revise my vote because I found a bug that should not be in >>> >> the >>> >> beta version. See patch and comment on MYFACES-2356 for details. >>> >> >>> >> rgards >>> >> Michael >>> >> >>> >> Am 22.01.2010 10:49, schrieb Jakob Korherr: >>> >>> >>> >>> +1 >>> >>> >>> >>> Regards, >>> >>> Jakob >>> >>> >>> >>> 2010/1/22 Michael Kurz <michi.k...@gmx.at <mailto:michi.k...@gmx.at>> >>> >>> >>> >>> +1 >>> >>> >>> >>> Am 22.01.2010 08:55, schrieb Gerhard Petracek: >>> >>> >>> >>> +1 >>> >>> >>> >>> regards, >>> >>> gerhard >>> >>> >>> >>> http://www.irian.at >>> >>> >>> >>> Your JSF powerhouse - >>> >>> JSF Consulting, Development and >>> >>> Courses in English and German >>> >>> >>> >>> Professional Support for Apache MyFaces >>> >>> >>> >>> >>> >>> >>> >>> 2010/1/22 Werner Punz <werner.p...@gmail.com >>> >>> <mailto:werner.p...@gmail.com> <mailto:werner.p...@gmail.com >>> >>> <mailto:werner.p...@gmail.com>>> >>> >>> >>> >>> >>> >>> +1 >>> >>> >>> >>> >>> >>> Matthias Wessendorf schrieb: >>> >>> >>> >>> +1 >>> >>> >>> >>> On Fri, Jan 22, 2010 at 7:03 AM, Leonardo Uribe >>> >>> <lu4...@gmail.com <mailto:lu4...@gmail.com> >>> >>> <mailto:lu4...@gmail.com <mailto:lu4...@gmail.com>>> wrote: >>> >>> >>> >>> Hi, >>> >>> >>> >>> I was running the needed tasks to get the >>> >>> 2.0.0-beta >>> >>> release >>> >>> of Apache >>> >>> MyFaces core out. >>> >>> >>> >>> The artifacts passed all TCK test that in my >>> >>> personal >>> >>> opinion should pass, >>> >>> but we can't claim it oficially, because we are >>> >>> waiting a >>> >>> response from Sun. >>> >>> >>> >>> Please note that this vote concerns all of the >>> >>> following parts: >>> >>> 1. Maven artifact group >>> >>> "org.apache.myfaces.shared" >>> >>> v4.0.1-beta [1] >>> >>> 2. Maven artifact group "org.apache.myfaces.core" >>> >>> v2.0.0-beta [1] >>> >>> >>> >>> The artifacts are deployed to my private Apache >>> >>> account ([1] >>> >>> and [3] for >>> >>> binary and source packages). >>> >>> >>> >>> The release notes could be found at [4]. >>> >>> >>> >>> Also the clirr test does not show binary >>> >>> incompatibilities >>> >>> with myfaces-api. >>> >>> >>> >>> Please take a look at the "2.0.0-beta" artifacts >>> >>> and >>> >>> vote! >>> >>> >>> >>> Please note: This vote is "majority approval" with >>> >>> a >>> >>> minimum >>> >>> of three >>> >>> +1 votes (see [3]). >>> >>> >>> >>> ------------------------------------------------ >>> >>> [ ] +1 for community members who have reviewed the >>> >>> bits >>> >>> [ ] +0 >>> >>> [ ] -1 for fatal flaws that should cause these bits >>> >>> not to >>> >>> be released, >>> >>> and why.............. >>> >>> ------------------------------------------------ >>> >>> >>> >>> Thanks, >>> >>> Leonardo Uribe >>> >>> >>> >>> [1] http://people.apache.org/~lu4242/myfaces200beta >>> >>> <http://people.apache.org/%7Elu4242/myfaces200beta> >>> >>> [2] >>> >>> http://www.apache.org/foundation/voting.html#ReleaseVotes >>> >>> [3] >>> >>> http://people.apache.org/~lu4242/myfaces200betabinsrc >>> >>> <http://people.apache.org/%7Elu4242/myfaces200betabinsrc> >>> >>> [4] http://issues.apache.org/jira/browse/MYFACES >>> >>> (jira is >>> >>> down at the time I >>> >>> wrote this) >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> > >>> > >> >> >
