[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851027#action_12851027
]
Jeanne Waldman commented on TRINIDAD-1680:
------------------------------------------
Hi,
The coding style is Code Style: JDeveloper Classic, Indentation Size/Tab Size
2, no tabs.
Put the arguments of a method on their own line, indented from the start of the
file.
When I applied your patch, I saw a lot of differences in styling. I was
expecting only differences in the lines of code you changed.
For example, in the original file, the parameters are like this
static public StyleSheetEntry parseCSSSource(
ParseContext context,
NameResolver resolver,
String sourceName,
Class<?> expectedType) throws IOException
and in yours it is like:
static public StyleSheetEntry parseCSSSource(ParseContext context,
NameResolver resolver,
String sourceName,
Class<?> expectedType)
throws IOException
I also saw some of the imports reordered. We like to have them in alphabetical
order.
I see import org.apache.myfaces.trinidadinternal.style.util.CSSUtils;
import org.apache.myfaces.trinidadinternal.style.util.StyleUtils;
have been moved before style.xml to after.
- Jeanne
I wonder if you selected 'Reformat' to reformat the file?
> Introduce include-property in CSS
> ---------------------------------
>
> Key: TRINIDAD-1680
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1680
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Components: Skinning
> Reporter: Marius Petoi
> Priority: Minor
> Attachments: includeProperty.patch, includeProperty.patch,
> includeProperty.patch, patchIncludeProperty.patch
>
>
> The include-property feature is present in the XSS, but it is not supported
> in the CSS. With this, we are one step closer to eliminating the old XSS
> files and replacing them with CSS. In the XSS files, the syntax of
> includeProperty is:
> <!-- AFVeryDarkForeground is the darkest foreground color in the core (green)
> color ramp -->
> <style name="AFVeryDarkForeground">
> <includeProperty name="AFVeryDarkBackground"
> propertyName="background-color"
> localPropertyName="color"/>
> </style>
> This should be ported to CSS also.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
