[ https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852031#action_12852031 ]
Jeanne Waldman commented on TRINIDAD-1680: ------------------------------------------ Thanks. This is formatted well, but unfortunately when I ran the test case it didn't work. I ran the panelPageSkinDemo.jspx in purple mode. I looked at the generated css file and I see: .af_commandButton,.af_goButton,.af_resetButton {font-family:Arial,Helvetica,Geneva,sans-serif;font-size:10pt;font-weight:normal;white-space:nowrap;background-color:Red;max-width:100px;color:white} So you see that the background-color:Red is being applied to af|goButton and af|resetButton as well, which is not right. It looks like the merging is not working correctly. For skinning changes, it's a good idea to save off the generated css file before your changes and then after your changes and compare the result. > Introduce include-property in CSS > --------------------------------- > > Key: TRINIDAD-1680 > URL: https://issues.apache.org/jira/browse/TRINIDAD-1680 > Project: MyFaces Trinidad > Issue Type: New Feature > Components: Skinning > Reporter: Marius Petoi > Priority: Minor > Attachments: includeProperty.patch, includeProperty.patch, > includeProperty.patch, patchIncludeProperty.patch, patchIncludeProperty.patch > > > The include-property feature is present in the XSS, but it is not supported > in the CSS. With this, we are one step closer to eliminating the old XSS > files and replacing them with CSS. In the XSS files, the syntax of > includeProperty is: > <!-- AFVeryDarkForeground is the darkest foreground color in the core (green) > color ramp --> > <style name="AFVeryDarkForeground"> > <includeProperty name="AFVeryDarkBackground" > propertyName="background-color" > localPropertyName="color"/> > </style> > This should be ported to CSS also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.