[ 
https://issues.apache.org/jira/browse/MYFACES-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880009#action_12880009
 ] 

Leonardo Uribe commented on MYFACES-2759:
-----------------------------------------

I see, the code on FacesContextFactoryImpl does not deal with this interface 
(and it should be). The intention in the code is use this interface. Maybe when 
I did that part I miss this point, but the idea is check if the current 
returned ExternalContext instance implements this interface, if not check if 
the first instance implements it and call the constructor properly.

In few words, the fact that the code is not used does not mean that the 
interfaces has no purpose, instead, means something is missing.

> Clean up FacesContextImpl
> -------------------------
>
>                 Key: MYFACES-2759
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2759
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>             Fix For: 2.0.2-SNAPSHOT
>
>
> There are currently some unnecessary init methods and contructor attributes 
> (ReleaseableExternalContext) on FacesContextImpl. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to