Hello, Thank you for your appreciation. I'm happy that I could make myself useful. So, the amount of reduced state is:
- about 60 Bytes for all the components that have at least a child facet with the removal of VISITED_FACET_COUNT - the size of the ATTACHED_OBJECT_HANDLERS_KEY, which was saved with the null value in the component attribute map. - the saved state of UIInput is reduced with 25% when validation is successful (valid is no longer saved, as the default value is true) and with 50% when validation fails (value and localValueSet respectively are no longer saved as they have the default values - null and respectively, false). Using Leonardo's partial state saving in tables from the JIRA issue https://issues.apache.org/jira/browse/MYFACES-2616, for a table of 1000 lines, the saved state is reduced from 150 KB to 120 KB, when validation passes. More work can be done in UIInput state saving, once the transient properties model that Leonardo proposed will be committed. Then some of the properties can be made transient. Regards, Marius On Wed, Aug 18, 2010 at 11:31 PM, Leonardo Uribe <lu4...@gmail.com> wrote: > Hi > > Yes, you did an excelent work. All those optimizations were difficult to > find. > > I think we still need to do some work to commit the improvement for remove > MARK_DELETED attribute. > > It could be good to know some numbers about these changes. > > regards, > > Leonardo Uribe > > 2010/8/18 Werner Punz <werner.p...@gmail.com> > > Hi any helping hand is welcome you did an outstanding job, and welcome to >> the "club". >> >> Btw. I am just a bystander to this issue, how much improvement did you get >> by all this measures, do you have any performance or size numbers? >> >> Werner >> >> >> Am 18.08.10 15:55, schrieb Marius Petoi: >> >> Hello, >>> >>> The improvements I made in the GSoC project regarding state saving are: >>> >>> - add the size of the saved state for each of the components in the >>> debug page. >>> - remove the VISITED_FACET_COUNT ATTRIBUTE attribute used by UIDebug >>> from the component attributes map >>> - remove ATTACHED_OBJECT_HANDLERS from the component's attribute map >>> - remove MARK_DELETED attribute from the component's attribute map >>> - modify UIInput components so that when no value has been set before >>> and an attempt to set the default value is made, this is not done. >>> - improve the invokeOnComponent and visitTree methods in UILeaf >>> components, which normally have no children. >>> >>> I want to continue working on the MyFaces project after the GSoC program >>> is finished. If you have any other suggestions about improvements on >>> state saving (and not only), please tell me. >>> >>> Best regards, >>> Marius >>> >> >> >> >
