got results back...your js change didn't regress anything, so things look good. ship it! :)
On Mon, Sep 20, 2010 at 12:50 PM, Leonardo Uribe <lu4...@gmail.com> wrote: > Hi > > Ok, sounds great. Let me know when you are done, so I can start the > procedure. > > Leonardo > > 2010/9/20 Michael Concini <mconc...@gmail.com> > > ok, it looks like the issue was related to the changes from > MYFACES-2895<https://issues.apache.org/jira/browse/MYFACES-2895>. >> Our HtmlUnit testing was checking that there was no messages field rendered >> when all input was valid. Looks like the code was changed a few weeks back >> to render an empty div. Since it looks like this behavior is consistent >> with the latest RI's behavior based on the discussion in the JIRA issue, >> I'll go ahead and update the test to handle the change in behavior. >> >> I'm going to do one more full run with Leo's latest javascript tweak, but >> it looks like we'll be good to go from our side of things. >> >> On Sun, Sep 19, 2010 at 6:19 PM, Michael Concini <mconc...@gmail.com>wrote: >> >>> Sorry for the delay...nearly all of the tests are still passing with the >>> latest code. I'm only seeing two new failures, both of them are tests that >>> involve the f:validateRegex tag. I haven't had any chance to look into what >>> might be going on yet...I'll start digging into it Monday. The only thing I >>> did do was check into the classes related to the validateRegex tag, but I >>> can't see anything that changed to my knowledge, and I can't be sure when it >>> would have started failing since I was a few weeks behind on syncing our >>> builds with the svn tree. >>> >>> >>> On Fri, Sep 17, 2010 at 10:06 AM, Michael Concini <mconc...@gmail.com>wrote: >>> >>>> Hi Werner, I'll try to run through our IBM tests this afternoon. >>>> >>>> >>>> On Fri, Sep 17, 2010 at 4:09 AM, Werner Punz <werner.p...@gmail.com>wrote: >>>> >>>>> Am 16.09.10 20:29, schrieb Leonardo Uribe: >>>>> >>>>> >>>>>> >>>>>> If someone has some issue in myfaces core that needs to be solved >>>>>> before >>>>>> release, this is a good time to tell it. >>>>>> >>>>> Curtiss, I guess this would be a good time to roll the IBM tests again >>>>> against the trunk. >>>>> Also Ganesh, as posted before, please give the stuff a testrun with >>>>> your complib. >>>>> >>>>> Werner >>>>> >>>>> >>>>> >>>> >>> >> >
