Having the actual revision number inside of the manifest.mf file is nice. However, not sure if that is really needed for every build, therefore I commented it out.
Perhaps this should be done only in the release profile ? What do you think ? -Matthias On Thu, Feb 10, 2011 at 7:05 PM, <mat...@apache.org> wrote: > Author: matzew > Date: Thu Feb 10 18:05:24 2011 > New Revision: 1069504 > > URL: http://svn.apache.org/viewvc?rev=1069504&view=rev > Log: > disabling the svn revision number plugin - should it be done only on release > profile??? > > Modified: > myfaces/trinidad/trunk/trinidad-api/pom.xml > myfaces/trinidad/trunk/trinidad-impl/pom.xml > > Modified: myfaces/trinidad/trunk/trinidad-api/pom.xml > URL: > http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-api/pom.xml?rev=1069504&r1=1069503&r2=1069504&view=diff > ============================================================================== > --- myfaces/trinidad/trunk/trinidad-api/pom.xml (original) > +++ myfaces/trinidad/trunk/trinidad-api/pom.xml Thu Feb 10 18:05:24 2011 > @@ -172,7 +172,8 @@ > <!-- > To make the current revision number, we use the > buildnumber-maven-plugin. > --> > - <plugin> > + <!-- Perhaps this should be only enabled on release profile ? --> > + <!--plugin> > <groupId>org.codehaus.mojo</groupId> > <artifactId>buildnumber-maven-plugin</artifactId> > <version>1.0-beta-4</version> > @@ -190,7 +191,7 @@ > <getRevisionOnlyOnce>true</getRevisionOnlyOnce> > <buildNumberPropertyName>scm.revision</buildNumberPropertyName> > </configuration> > - </plugin> > + </plugin--> > > <plugin> > <groupId>org.apache.maven.plugins</groupId> > > Modified: myfaces/trinidad/trunk/trinidad-impl/pom.xml > URL: > http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/pom.xml?rev=1069504&r1=1069503&r2=1069504&view=diff > ============================================================================== > --- myfaces/trinidad/trunk/trinidad-impl/pom.xml (original) > +++ myfaces/trinidad/trunk/trinidad-impl/pom.xml Thu Feb 10 18:05:24 2011 > @@ -211,7 +211,8 @@ > <!-- > To make the current revision number, we use the > buildnumber-maven-plugin. > --> > - <plugin> > + <!-- Perhaps this should be only enabled on release profile ? --> > + <!--plugin> > <groupId>org.codehaus.mojo</groupId> > <artifactId>buildnumber-maven-plugin</artifactId> > <version>1.0-beta-4</version> > @@ -229,7 +230,7 @@ > <getRevisionOnlyOnce>true</getRevisionOnlyOnce> > <buildNumberPropertyName>scm.revision</buildNumberPropertyName> > </configuration> > - </plugin> > + </plugin--> > > <plugin> > <groupId>org.apache.maven.plugins</groupId> > > > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
