+1, I totally agree with Bernd.. Releases have VERSION numbers. It's snapshots that need revision and I see no harm either way.
On Feb 11, 2011, at 2:44 AM, Gerhard <gerhard.petra...@gmail.com> wrote: hi, +1 for adding the revision number in any case. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/2/11 Volker Weber <v.we...@inexso.de> > Hi, > > i agree to Bernd, the revision number for a release is not needed, but > what is the Problem having this few more lines in any manifest? > I would prefer having this info packaged. > > Regards, > Volker > > > 2011/2/10 Bernd Bohmann <bernd.bohm...@googlemail.com>: > > Hello Matthias, > > > > For a release the revision number is not needed. For a snapshot it might > be > > helpful if someone reports a bug and it's not clear with revision was the > > base for the snapshot. > > > > Regards > > > > Bernd > > > > Am 10.02.2011 19:23 schrieb "Matthias Wessendorf" <mat...@apache.org>: > >> Having the actual revision number inside of the manifest.mf file is > nice. > >> > >> However, not sure if that is really needed for every build, therefore > >> I commented it out. > >> > >> Perhaps this should be done only in the release profile ? > >> > >> What do you think ? > >> > >> -Matthias > >> > >> On Thu, Feb 10, 2011 at 7:05 PM, <mat...@apache.org> wrote: > >>> Author: matzew > >>> Date: Thu Feb 10 18:05:24 2011 > >>> New Revision: 1069504 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=1069504&view=rev > >>> Log: > >>> disabling the svn revision number plugin - should it be done only on > >>> release profile??? > >>> > >>> Modified: > >>> myfaces/trinidad/trunk/trinidad-api/pom.xml > >>> myfaces/trinidad/trunk/trinidad-impl/pom.xml > >>> > >>> Modified: myfaces/trinidad/trunk/trinidad-api/pom.xml > >>> URL: > >>> > http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-api/pom.xml?rev=1069504&r1=1069503&r2=1069504&view=diff > >>> > >>> > ============================================================================== > >>> --- myfaces/trinidad/trunk/trinidad-api/pom.xml (original) > >>> +++ myfaces/trinidad/trunk/trinidad-api/pom.xml Thu Feb 10 18:05:24 > 2011 > >>> @@ -172,7 +172,8 @@ > >>> <!-- > >>> To make the current revision number, we use the > >>> buildnumber-maven-plugin. > >>> --> > >>> - <plugin> > >>> + <!-- Perhaps this should be only enabled on release profile ? > --> > >>> + <!--plugin> > >>> <groupId>org.codehaus.mojo</groupId> > >>> <artifactId>buildnumber-maven-plugin</artifactId> > >>> <version>1.0-beta-4</version> > >>> @@ -190,7 +191,7 @@ > >>> <getRevisionOnlyOnce>true</getRevisionOnlyOnce> > >>> > <buildNumberPropertyName>scm.revision</buildNumberPropertyName> > >>> </configuration> > >>> - </plugin> > >>> + </plugin--> > >>> > >>> <plugin> > >>> <groupId>org.apache.maven.plugins</groupId> > >>> > >>> Modified: myfaces/trinidad/trunk/trinidad-impl/pom.xml > >>> URL: > >>> > http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/pom.xml?rev=1069504&r1=1069503&r2=1069504&view=diff > >>> > >>> > ============================================================================== > >>> --- myfaces/trinidad/trunk/trinidad-impl/pom.xml (original) > >>> +++ myfaces/trinidad/trunk/trinidad-impl/pom.xml Thu Feb 10 18:05:24 > 2011 > >>> @@ -211,7 +211,8 @@ > >>> <!-- > >>> To make the current revision number, we use the > >>> buildnumber-maven-plugin. > >>> --> > >>> - <plugin> > >>> + <!-- Perhaps this should be only enabled on release profile ? > --> > >>> + <!--plugin> > >>> <groupId>org.codehaus.mojo</groupId> > >>> <artifactId>buildnumber-maven-plugin</artifactId> > >>> <version>1.0-beta-4</version> > >>> @@ -229,7 +230,7 @@ > >>> <getRevisionOnlyOnce>true</getRevisionOnlyOnce> > >>> > <buildNumberPropertyName>scm.revision</buildNumberPropertyName> > >>> </configuration> > >>> - </plugin> > >>> + </plugin--> > >>> > >>> <plugin> > >>> <groupId>org.apache.maven.plugins</groupId> > >>> > >>> > >>> > >> > >> > >> > >> -- > >> Matthias Wessendorf > >> > >> blog: http://matthiaswessendorf.wordpress.com/ > >> sessions: http://www.slideshare.net/mwessendorf > >> twitter: http://twitter.com/mwessendorf > > > > > > -- > inexso - information exchange solutions GmbH > Ofener Str. 30 | 26121 Oldenburg > Tel.: +49 441 219 730 56 | > FAX: +49 441 219 730 66 | eMail: volker.we...@inexso.de > > Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 > Geschäftsführer: Stefan Schulte, Michael Terschüren >
