This plugin actually kind of worries me if used on released code. Unless we use a timestamp type build id, I think ANY revision of tagged code should be unknown. It's not like people are going to commit their changes to the tag, this allowing a unique number to be calculated.
What do we use this for, debugging? If so, I'm wondering if we could only allow this to be executed with snapshots and allow everything else to be unknown.. Scott On Feb 15, 2011, at 3:18 AM, Matthias Wessendorff <mat...@apache.org> wrote: > On Tue, Feb 15, 2011 at 11:11 AM, Rudy De Busscher > <rdebussc...@gmail.com> wrote: >> Matthias, >> >> Can it be activated only for the release procedure? with the profile >> apache-release? > > it does not make sense to do it only on releases - as they are always > from a TAG, > hence the revision is known. > >> >> It will also fail on computers that don't have a command line SVN client >> installed. That is also the reason why we abandoned it in the company >> projects. > > I think Bernd's suggestion is the right one. > > -Matthias > >> >> regards >> Rudy. >> >> >> On 15 February 2011 11:07, Bernd Bohmann <bernd.bohm...@googlemail.com> >> wrote: >>> >>> Hello Matze, >>> >>> good point. I think the revisionOnScmFailure parameter should be set >>> to 'unkown'. >>> >>> Regards >>> >>> Bernd >>> >>> On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf <mat...@apache.org> >>> wrote: >>>> Downloaded the source: >>>> >>>> >>>> https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip >>>> >>>> did an unzip and "mvn clean install" >>>> >>>> I am getting this "error": >>>> [INFO] [buildnumber:create {execution: default}] >>>> [INFO] Checking for local modifications: skipped. >>>> [INFO] Updating project files from SCM: skipped. >>>> [INFO] Executing: /bin/sh -c cd >>>> /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api && >>>> svn --non-interactive info >>>> [INFO] Working directory: >>>> /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api >>>> Provider message: >>>> The svn command failed. >>>> Command output: >>>> svn: '.' is not a working copy >>>> >>>> [INFO] >>>> ------------------------------------------------------------------------ >>>> [ERROR] BUILD ERROR >>>> [INFO] >>>> ------------------------------------------------------------------------ >>>> [INFO] Cannot get the revision information from the scm repository : >>>> Error! >>>> >>>> >>>> This is due to the "buildnumber-maven-plugin", not sure if that should >>>> be really _always_ enabled... >>>> >>>> Looks like I can't download the soruce and build it, since the target >>>> folder (of my unzip) is (of course) >>>> not "SVN folder". >>>> >>>> Any hints? >>>> >>>> -Matthias >>>> >>>> >>>> >>>> >>>> On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan <darkar...@gmail.com> >>>> wrote: >>>>> +1 >>>>> >>>>> On 02/15/2011 02:09 AM, Scott O'Bryan wrote: >>>>>> >>>>>> Okay, so my first hickup. I forgot to include the voting part. :D >>>>>> >>>>>> ------------------------------------------------ >>>>>> [ ] +1 for community members who have reviewed the bits >>>>>> [ ] +0 >>>>>> [ ] -1 for fatal flaws that should cause these bits not to be >>>>>> released, >>>>>> and why.............. >>>>>> ------------------------------------------------ >>>>>> >>>>>> Thanks, >>>>>> Scott >>>>>> >>>>>> On 02/15/2011 01:59 AM, Scott O'Bryan wrote: >>>>>>> >>>>>>> Hey all, >>>>>>> >>>>>>> I was running the tasks needed to get the Trinidad 2.0.0-beta-2 >>>>>>> release >>>>>>> out and now I need a vote as to whether everything looks good or not. >>>>>>> This >>>>>>> is still a beta release so there are still a few open bugs, but all >>>>>>> of the >>>>>>> unit tests pass and this beta has undergone some considerable >>>>>>> testing. >>>>>>> >>>>>>> I have deployed the artifacts to the Nexus Repository [1] for review. >>>>>>> The release notes for the Trinidad 2.0.0-beta-2 release are on the >>>>>>> JIRA >>>>>>> site [2] for review as well. >>>>>>> >>>>>>> This vote will remain open for at least 72 hours. >>>>>>> >>>>>>> Thanks, >>>>>>> Scott O'Bryan >>>>>>> >>>>>>> PS- This is my first release of Trinidad since moving over to NEXUS, >>>>>>> so a >>>>>>> lot of scrutiny and your suggestions would be much appreciated. >>>>>>> >>>>>>> [1] >>>>>>> >>>>>>> https://repository.apache.org/content/repositories/orgapachemyfaces-005/ >>>>>>> [2] >>>>>>> >>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661&version=12316092 >>>>>>> >>>>>>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661&version=12316092> >>>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Matthias Wessendorf >>>> >>>> blog: http://matthiaswessendorf.wordpress.com/ >>>> sessions: http://www.slideshare.net/mwessendorf >>>> twitter: http://twitter.com/mwessendorf >>>> >> >> > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf
