Actually I am sorry, I did not read the mail thoroughly and vice vers.
The CSS fix definitely will be enabled by default,
what I was talking about is calling the onload handlers in the case if set.
The CSS fix is uncritical and is definitely a bug since it is a content
update, and updating the css is spec compliant.
The onload handler calling in viewbody and viewroot case is a spec hole,
and I will enable it only via a config param.
Werner
Am 10/13/11 12:57 AM, schrieb Werner Punz:
Actually the problem by enabling it by default simply is that there is a
high chance that we break the existing complibs, after all we have
a common behavior with mojarra here. This change has such a huge impact
that if it is done it must be done in conjunction with mojarra.
Werner
Am 10/12/11 11:45 PM, schrieb Leonardo Uribe:
2011/10/12 Werner Punz<werner.p...@gmail.com>:
Am 10/12/11 10:17 PM, schrieb Leonardo Uribe:
Good question. I agree with you about clear this up with the jsf eg
guys, but I think we should at least fix the problem with the
stylesheets (and maybe do the script replacement) on the "mean time".
For the scope of MYFACES-3106, this is the only concern.
I just talked to Ed Burns regarding it, and he told me to leave it
out for
now. I probably will enable it via a config switch like we have it for
iframe ppr event queuing different transports etc... And leave it off
per
default so that we have it in for users who want to use this stuff.
Really I would like to have it enabled by default. For example look
this example:
<h:commandButton ...>
<f:ajax render="content"/>
</h:commandButton>
<f:subview id="content">
...
<c:if test="#{...}">
<my:customComponent ....>
</c:if>
...
</f:subview>
customComponent.xhtml
<cc:implementation>
<h:outputStylesheet ..../>
....
</cc:implementation>
Without the fix it will fail. Note h:outputStylesheet target all
stylesheets by default to<head>. Note that f:ajax render="@all" is
not used, so in theory the jsf implementation is responsible to detect
if a resource was added to head target and if that so, send an
additional<update id="javax.faces.ViewHead"> automatically. Why the
developer has to worry about an internal detail of a composite
component when using f:ajax?. It just breaks encapsulation principle.
The point is in my personal opinion there is no reason why leave it
out for now or disable it by default. It is technically feasible,
doesn't break the spec, and if Mojarra don't want to implement it
doesn't mean we should do the same.
Anyway, have a config switch to enable it is better than nothing, and
later we can fix it properly, getting rid the need of the switch. So
+1 to fix it, and ++1 to fix it and leave it enabled by default.
regards,
Leonardo Uribe
Werner
