[
https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134750#comment-13134750
]
Leonardo Uribe commented on MYFACES-3368:
-----------------------------------------
Just one comment: apply this checkstyle will make harder keep in sync 2.0.x
branch, because it mess up almost all files. Now, to apply a patch in both
branches it is required to rewrite some parts and a svn merge from 2.0.x to
2.1.x will not work well. The right way to do it is apply on 2.0.x first and
then on 2.1.x. Inclusive, there are some parts that change java api signature,
introducing bugs on the TCK. By that reason, I'm forced to check every single
file it was committed, wasting a lot of time. Please be more careful next time.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually
> only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take
> some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
