[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138042#comment-13138042 ]
Leonardo Uribe commented on MYFACES-3368: ----------------------------------------- Ok, no problem, but give me some time, I want to commit MYFACES-3259 first and this patch changes ComponentTagHandlerDelegate#apply. The one I really don't want to change is FaceletViewDeclarationLanguage#retargetMethodExpressions, because it is a difficult algorithm and have it as is makes easier read it and update it. But I have lots of junit tests for that one, so after all it is ok to refactor it. > enable 'standard' checkstyle checks in myfaces-core > --------------------------------------------------- > > Key: MYFACES-3368 > URL: https://issues.apache.org/jira/browse/MYFACES-3368 > Project: MyFaces Core > Issue Type: Improvement > Affects Versions: 2.1.3 > Reporter: Mark Struberg > Assignee: Leonardo Uribe > > We currently only have the 'minimal' checks enabled in core, which actually > only checks the correct license headers. > We should go for the 'standard' checkstyle rules, even if this would take > some time to fix (found 1111 errors only in the first module). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira