Re: [VOTE] Release of MyFaces Core 2.2.3

[Leonardo Uribe]

Hi

I have tried adding this fragment on core/parent/pom.xml

        <profile>
            <id>prepare-release</id>
            <activation>
                <property>
                    <name>prepareRelease</name>
                </property>
            </activation>
            <build>
                <plugins>
                    <plugin>
                        <artifactId>maven-release-plugin</artifactId>
                        <configuration>
                            <arguments>-DprepareRelease</arguments>
                        </configuration>
                    </plugin>
                    <plugin>
                        <groupId>org.apache.rat</groupId>
                        <artifactId>apache-rat-plugin</artifactId>
                        <executions>
                          <execution>
                            <phase>verify</phase>
                            <goals>
                              <goal>check</goal>
                            </goals>
                          </execution>
                        </executions>
                    </plugin>
                </plugins>
            </build>
        </profile>

It works, so I'll run again the release procedure and send another
vote request to the mailing list.

regards,

Leonardo Uribe


2014-04-17 13:42 GMT+02:00 Leonardo Uribe <lu4...@gmail.com>:
> I usually do wiki page for each release. The one for 2.2.3 is here:
>
> http://wiki.apache.org/myfaces/CoreRelease223
>
> There are two options, or we put the rat plugin command at the beginning,
> or we add the plugin when the release preparations are done. The idea is
> if a file miss the license, the rat plugin will stop the release when:
>
> mvn release:prepare
> -DtagBase=https://svn.apache.org/repos/asf/myfaces/shared/tags
> -DdryRun=true
>
> is executed. For example, clirr plugin and animal sniffer plugin are
> executed in that way. I'll check how can we do it, and fix it once for all.
> The only thing I don't like with this situation is execute the TCK again,
> because it usually takes some time, so probably the next vote
> attempt will be on this weekend.
>
> regards,
>
> Leonardo Uribe
>
>
> 2014-04-17 13:19 GMT+02:00 Mike Kienenberger <mkien...@gmail.com>:
>> On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe <lu4...@gmail.com> wrote:
>>> The problem is rat plugin is
>>> never executed automatically as part of the release, so there is no chance
>>> to detect and fix it early. I'll take a look at that.
>>
>> I really hate having to vote against a release just because we missed
>> license headers.   Even if we can't make running rat an automatic part
>> of the release maven task, maybe you can add a new step (mvn
>> apache-rat:check) in the release process document of running rat so it
>> always happens?   I wasn't sure what you are using as a template for
>> each release document or I would have added the step in there myself.