[
https://issues.apache.org/jira/browse/MYFACES-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511257#comment-16511257
]
ASF GitHub Bot commented on MYFACES-4237:
-----------------------------------------
pnicolucci opened a new pull request #7: MYFACES-4237: improve performance when
checking for duplicate ids
URL: https://github.com/apache/myfaces/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [perf] Performance update when checking for duplicate ids
> ---------------------------------------------------------
>
> Key: MYFACES-4237
> URL: https://issues.apache.org/jira/browse/MYFACES-4237
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-372
> Affects Versions: 2.2.12, 2.3.1
> Reporter: Paul Nicolucci
> Assignee: Paul Nicolucci
> Priority: Minor
> Fix For: 2.2.13, 2.3.2
>
>
> In
> org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java
> we currently do the following:
> {code:java}
> if (existingIds.contains (id)) {
> ....
> }
> {code}
> We can increase performance by doing the following:
> {code:java}
> if (!existingIds.add (id)) {
> ....
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
