[
https://issues.apache.org/jira/browse/MYFACES-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511260#comment-16511260
]
ASF GitHub Bot commented on MYFACES-4237:
-----------------------------------------
pnicolucci closed pull request #7: MYFACES-4237: improve performance when
checking for duplicate ids
URL: https://github.com/apache/myfaces/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java
index f0dd9c4c7..0543196f3 100644
---
a/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java
+++
b/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java
@@ -55,14 +55,12 @@ private static void checkIdsStatefulComponents
(FacesContext context,
id = component.getClientId (context);
- if (existingIds.contains (id))
+ if (!existingIds.add (id))
{
DuplicateIdException duplicateIdException =
createAndQueueException(context, component, id);
throw duplicateIdException;
}
- existingIds.add (id);
-
int facetCount = component.getFacetCount();
if (facetCount > 0)
{
@@ -102,14 +100,12 @@ private static void checkIds (FacesContext context,
UIComponent component, Set<S
id = component.getClientId (context);
- if (existingIds.contains (id))
+ if (!existingIds.add (id))
{
DuplicateIdException duplicateIdException =
createAndQueueException(context, component, id);
throw duplicateIdException;
}
- existingIds.add (id);
-
int facetCount = component.getFacetCount();
if (facetCount > 0)
{
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [perf] Performance update when checking for duplicate ids
> ---------------------------------------------------------
>
> Key: MYFACES-4237
> URL: https://issues.apache.org/jira/browse/MYFACES-4237
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-372
> Affects Versions: 2.2.12, 2.3.1
> Reporter: Paul Nicolucci
> Assignee: Paul Nicolucci
> Priority: Minor
> Fix For: 2.2.13, 2.3.2
>
>
> In
> org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java
> we currently do the following:
> {code:java}
> if (existingIds.contains (id)) {
> ....
> }
> {code}
> We can increase performance by doing the following:
> {code:java}
> if (!existingIds.add (id)) {
> ....
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
