Mike,
You bring up a great point. This is what the GitHub Actions workflow does.
mvn -B -V clean verify checkstyle:check apache-rat:check -Dformats=XML
-DchromeDriverVersion=112.0.5615.49 -f pom.xml
Where it forces a specific chrome driver. Not great i agree.
On 5/22/2023 7:59 AM, Mike Kienenberger wrote:
So I was trying to run the checklist to vote on MyFaces Core 4.0.1
(first time in a long while when I've had time), but I couldn't get
past trying to build the project from source.
The build process is downloading ChromeDriver 113.0.5672.63 for
integration tests but my version of linux is still at chromium
112.0.5615.165.
I could not figure out how to change the version of chromedriver used
for the test.
This does bring up a build-reproducibility issue though. If the build
depends on the end-user having a specific version of chromium
installed, this will cause issues down the road as the released
artifacts get older. Not sure if there's a simple solution for this,
though. If I have time later, I'll probably try running the build
from a docker container with the expected version of chrome
installed. Since Volodymyr already thinks we should not release yet,
I guess there's no time pressure.
On Wed, May 17, 2023 at 8:42 PM Thomas Andraschko
<andraschko.tho...@gmail.com> wrote:
+1
Melloware <melloware...@gmail.com> schrieb am Mi., 17. Mai 2023,
22:11:
+1
On 5/17/2023 3:52 PM, Volodymyr Siedlecki wrote:
> Hi,
>
> I was running the needed tasks to get the 4.0.1 release of
Apache
> MyFaces core out.
>
> Please note that this vote concerns all of the following parts:
> 1. Maven artifact group "org.apache.myfaces.core" v4.0.1 [1]
>
> The artifacts were deployed on nexus repo [1] for binary and
source
> packages.
>
> The release notes could be found at [4].
>
> The japicmp tool shows no binary incompatibilities with
4.0.1 when
> compared to the previous 4.0.0 jar. Please take a look at
the attached
> results.html.
> If requested, I can provide a comparison to the Jakarta
Faces 4.0.1 API.
>
> This release has not yet been run against the TCK, but I am
working to
> create a build which will run against the TCK. I hope to
have results
> by May 19.
>
> Please take a look at the "4.0.1" artifacts and vote! (see [3])
>
> Please note: This vote is "majority approval" with a minimum
of three
> +1 votes (see [2]).
>
> ------------------------------------------------
> [ ] +1 for community members who have reviewed the bits
> [ ] +0
> [ ] -1 for fatal flaws that should cause these bits not to be
> released, and why.
> ------------------------------------------------
>
> Thanks,
>
> Volodymyr
>
> [1]
>
https://repository.apache.org/content/repositories/orgapachemyfaces-1231/org/apache/myfaces/core/
> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
> [3]
>
https://repository.apache.org/content/repositories/orgapachemyfaces-1231/org/apache/myfaces/core/myfaces-core-assembly/
> [4]
>
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978>
>
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12352978>>
>
--
Melloware
melloware@
--
Melloware
melloware@
