Fine with me too :-)

> On Nov 8, 2019, at 8:02 AM, marko kiiskila <ma...@runtime.io> wrote:
> 
> 
> 
>> On 7 Nov 2019, at 16.50, Christopher Collins <ch...@runtime.io> wrote:
>> 
>> On Thu, Nov 07, 2019 at 11:56:36AM -0800, Vipul Rahane wrote:
>>> Hello,
>>> 
>>> LOG_VERSION 2 has been around for quite some time but is mostly just a
>>> string based log. LOG_VERSION 3 supports string based logs as well as
>>> others. LOG_VERSION 2 does not play well with the MCUmgr mobile library as
>>> well.
>>> 
>>> I would like to suggest getting rid of LOG_VERSION 2 which would allow us
>>> to make the code a bit simpler and not worrying about backwards
>>> compatibility.
>>> 
>>> This discussion was mainly triggered by a PR
>>> https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding back
>>> string based reboot log just to make it work with LOG_VERSION 2.
>>> 
>>> LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library.
>>> 
>>> I suggest we deprecate LOG_VERSION 2 and make the default 3 going forward.
>> 
>> I agree.  Version 3 has been around for quite a while (two years?) and
>> it is superior to version 2.  I am fine with dropping support for
>> version 2.
>> 
> 
> I’d ok with that one as well.

Reply via email to